Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2692863013: Assert that |resource| is always non-null in requestPendingScript() (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that |resource| is always non-null in requestPendingScript() BUG=686281 Review-Url: https://codereview.chromium.org/2692863013 Cr-Commit-Position: refs/heads/master@{#451986} Committed: https://chromium.googlesource.com/chromium/src/+/e359f31a6ca4013fcf2668ad3e5a1c53ae217983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
hiroshige
PTAL.
3 years, 10 months ago (2017-02-17 23:18:26 UTC) #8
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-02-18 21:07:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692863013/1
3 years, 10 months ago (2017-02-22 07:33:03 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:51:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e359f31a6ca4013fcf2668ad3e5a...

Powered by Google App Engine
This is Rietveld 408576698