Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: media/gpu/avda_picture_buffer_manager.cc

Issue 2692863011: Add ContentVideoViewOverlay to AVDA. (Closed)
Patch Set: keep |overlay| longer in UpdateSurface, comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/avda_picture_buffer_manager.cc
diff --git a/media/gpu/avda_picture_buffer_manager.cc b/media/gpu/avda_picture_buffer_manager.cc
index eca3872b315fc06f3137cad6458c1ffccd14b45d..08198aba1c7ce68d2f22dd1155fc5afdb66746e0 100644
--- a/media/gpu/avda_picture_buffer_manager.cc
+++ b/media/gpu/avda_picture_buffer_manager.cc
@@ -16,11 +16,11 @@
#include "gpu/command_buffer/service/gl_stream_texture_image.h"
#include "gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h"
#include "gpu/command_buffer/service/texture_manager.h"
-#include "gpu/ipc/common/gpu_surface_lookup.h"
#include "gpu/ipc/service/gpu_channel.h"
#include "media/base/android/media_codec_bridge_impl.h"
#include "media/gpu/avda_codec_image.h"
#include "media/gpu/avda_shared_state.h"
+#include "ui/gl/android/scoped_java_surface.h"
#include "ui/gl/android/surface_texture.h"
#include "ui/gl/egl_util.h"
#include "ui/gl/gl_bindings.h"
@@ -79,15 +79,16 @@ AVDAPictureBufferManager::AVDAPictureBufferManager(
AVDAPictureBufferManager::~AVDAPictureBufferManager() {}
-gl::ScopedJavaSurface AVDAPictureBufferManager::Initialize(int surface_id) {
+void AVDAPictureBufferManager::InitializeForOverlay() {
shared_state_ = new AVDASharedState();
surface_texture_ = nullptr;
+}
- // Acquire the SurfaceView surface if given a valid id.
- if (surface_id != SurfaceManager::kNoSurfaceID)
- return gpu::GpuSurfaceLookup::GetInstance()->AcquireJavaSurface(surface_id);
+gl::ScopedJavaSurface AVDAPictureBufferManager::InitializeForSurfaceTexture() {
+ shared_state_ = new AVDASharedState();
+ surface_texture_ = nullptr;
- // Otherwise create a SurfaceTexture.
+ // Create a SurfaceTexture.
GLuint service_id;
surface_texture_ = CreateAttachedSurfaceTexture(
state_provider_->GetGlDecoder(), &service_id);

Powered by Google App Engine
This is Rietveld 408576698