Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2692863009: Remove usage of ws::Display in ws::UserDisplayManager. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by kylechar (OOO until 5-29)
Modified:
3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, fwang, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of ws::Display in ws::UserDisplayManager. For external mode we do not have one ws::Display per display::Display. Have ws::UserDisplayManager take in a display::Display directly instead of getting them from ws::Display. Also get list of current displays from display::Screen instead of ws::DisplayManager. BUG=693081 Review-Url: https://codereview.chromium.org/2692863009 Cr-Commit-Position: refs/heads/master@{#451841} Committed: https://chromium.googlesource.com/chromium/src/+/310a283e2982013c42652daa4af5c2ad621a5013

Patch Set 1 #

Patch Set 2 : Fix includes. #

Patch Set 3 : Fix mash_browser_tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -90 lines) Patch
M services/ui/display/screen_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/display/screen_manager_ozone_external.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/display/screen_manager_ozone_external.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/display/screen_manager_ozone_internal.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M services/ui/display/screen_manager_ozone_internal.cc View 1 2 3 chunks +10 lines, -11 lines 0 comments Download
M services/ui/display/screen_manager_stub_internal.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M services/ui/display/screen_manager_stub_internal.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/display_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 chunks +36 lines, -18 lines 0 comments Download
M services/ui/ws/user_display_manager.h View 1 4 chunks +9 lines, -11 lines 0 comments Download
M services/ui/ws/user_display_manager.cc View 1 5 chunks +29 lines, -28 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (15 generated)
kylechar (OOO until 5-29)
3 months, 1 week ago (2017-02-16 20:20:34 UTC) #2
sky
LGTM
3 months, 1 week ago (2017-02-16 22:11:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692863009/40001
3 months ago (2017-02-21 19:03:00 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 months ago (2017-02-21 21:06:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692863009/40001
3 months ago (2017-02-21 21:21:08 UTC) #18
commit-bot: I haz the power
3 months ago (2017-02-21 21:52:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/310a283e2982013c42652daa4af5...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06