Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692863007:
Add a DCHECK to ensure that WindowTreeClient has a delegate (Closed)
DescriptionAdd a DCHECK to ensure that WindowTreeClient has a delegate
It is assumed in various places from WindowTreeClient that a delegate_
is available. This CL adds a DCHECK in the constructor to ensure that
this assumption holds.
BUG=None
Review-Url: https://codereview.chromium.org/2692863007
Cr-Commit-Position: refs/heads/master@{#451445}
Committed: https://chromium.googlesource.com/chromium/src/+/dc652be25ec1400b7f120a96398e5a7de89b4cd4
Patch Set 1 #
Total comments: 1
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by fwang@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fwang@igalia.com changed reviewers: + sadrul@chromium.org
PTAL
fwang@igalia.com changed reviewers: + sky@chromium.org
tonikitoo@igalia.com changed reviewers: + tonikitoo@igalia.com
https://codereview.chromium.org/2692863007/diff/1/ui/aura/mus/window_tree_cli... File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2692863007/diff/1/ui/aura/mus/window_tree_cli... ui/aura/mus/window_tree_client.cc:181: DCHECK(delegate_); alternatively, we could make 'delegate_' a reference instead, but it would be a bigger CL.
LGTM - we generally don't use references for thinks like delegate.
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487402911880870, "parent_rev":
"8321924b7cec59300d820107a8f8e38fdc1949f7", "commit_rev":
"dc652be25ec1400b7f120a96398e5a7de89b4cd4"}
Message was sent while issue was closed.
Description was changed from ========== Add a DCHECK to ensure that WindowTreeClient has a delegate It is assumed in various places from WindowTreeClient that a delegate_ is available. This CL adds a DCHECK in the constructor to ensure that this assumption holds. BUG=None ========== to ========== Add a DCHECK to ensure that WindowTreeClient has a delegate It is assumed in various places from WindowTreeClient that a delegate_ is available. This CL adds a DCHECK in the constructor to ensure that this assumption holds. BUG=None Review-Url: https://codereview.chromium.org/2692863007 Cr-Commit-Position: refs/heads/master@{#451445} Committed: https://chromium.googlesource.com/chromium/src/+/dc652be25ec1400b7f120a96398e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dc652be25ec1400b7f120a96398e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
