Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 2692863004: Supply signin dialog with credentials if available. (Closed)

Created:
3 years, 10 months ago by palar
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show reauth dialog instead of signin dialog when trying to open a locked profile. BUG=687894 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2692863004 Cr-Commit-Position: refs/heads/master@{#450386} Committed: https://chromium.googlesource.com/chromium/src/+/58084dd8f1d79ce115ee976daa4f1d6b8d51481b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M chrome/browser/ui/webui/profile_helper.cc View 4 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
palar
3 years, 10 months ago (2017-02-14 16:02:15 UTC) #1
Bernhard Bauer
Code LGTM, but I think a better description would be "Show reauth dialog instead of ...
3 years, 10 months ago (2017-02-14 16:07:53 UTC) #2
palar
On 2017/02/14 16:07:53, Bernhard Bauer wrote: > Code LGTM, but I think a better description ...
3 years, 10 months ago (2017-02-14 16:10:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692863004/1
3 years, 10 months ago (2017-02-14 16:10:39 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 17:05:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58084dd8f1d79ce115ee976daa4f...

Powered by Google App Engine
This is Rietveld 408576698