Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2692853013: Misc. fixes to MashRunner environment (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Misc. fixes to MashRunner environment - Adds simple_wm to the chrome --mash catalog - Allows chrome_mash to connect to anything (to support dynamic window manager selection without manifest updates) - Re-lands change to make MashRunner connect to content_packaged_services to launch the browser, rather than connecting to content_browser BUG=672614 Review-Url: https://codereview.chromium.org/2692853013 Cr-Commit-Position: refs/heads/master@{#451168} Committed: https://chromium.googlesource.com/chromium/src/+/98ec036d053570d83cbad754e229b68e4984bed9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/app/mash/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Ken Rockot(use gerrit already)
since i know you like code reviews so much
3 years, 10 months ago (2017-02-16 22:13:30 UTC) #3
sky
LGTM
3 years, 10 months ago (2017-02-16 22:36:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692853013/1
3 years, 10 months ago (2017-02-16 22:58:17 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 01:40:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98ec036d053570d83cbad754e229...

Powered by Google App Engine
This is Rietveld 408576698