Only allow explicitly whitelisted users to issue lease requests to Machine Provider

Only allow explicitly whitelisted users to issue lease requests to Machine Provider

BUG=692411
Review-Url: https://codereview.chromium.org/2692853012
Committed: https://github.com/luci/luci-py/commit/7b49f6e0a9a9093f2a572d6c44e6996b992ec785

[smut, 2017-02-15 23:53:21]

smut@google.com changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2017-02-15 23:59:02]

lgtm

https://codereview.chromium.org/2692853012/diff/1/appengine/machine_provider/...
File appengine/machine_provider/handlers_endpoints_test.py (right):

https://codereview.chromium.org/2692853012/diff/1/appengine/machine_provider/...
appengine/machine_provider/handlers_endpoints_test.py:563: self.mock(acl.auth,
'is_group_member', lambda *args, **kwargs: True)
I'd prefer one that check the group name (so probably extracted itself in a
function) but I don't mind much.

[smut, 2017-02-16 01:15:10]

https://codereview.chromium.org/2692853012/diff/1/appengine/machine_provider/...
File appengine/machine_provider/handlers_endpoints_test.py (right):

https://codereview.chromium.org/2692853012/diff/1/appengine/machine_provider/...
appengine/machine_provider/handlers_endpoints_test.py:563: self.mock(acl.auth,
'is_group_member', lambda *args, **kwargs: True)
On 2017/02/15 23:59:02, M-A Ruel wrote:
> I'd prefer one that check the group name (so probably extracted itself in a
> function) but I don't mind much.

Done.

[smut, 2017-02-16 01:19:47]

The CQ bit was checked by smut@google.com

[smut, 2017-02-16 01:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2692853012/#ps20001
(title: "Fix")

[commit-bot: I haz the power, 2017-02-16 01:19:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:21:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487207987017740,
"parent_rev": "a30b2c6020682bf6aaf4cf210c3a828223ec0f3b", "commit_rev":
"7b49f6e0a9a9093f2a572d6c44e6996b992ec785"}

[commit-bot: I haz the power, 2017-02-16 01:21:53]

Description was changed from

==========
Only allow explicitly whitelisted users to issue lease requests to Machine
Provider

BUG=692411
==========

to

==========
Only allow explicitly whitelisted users to issue lease requests to Machine
Provider

BUG=692411

Review-Url: https://codereview.chromium.org/2692853012
Committed:
https://github.com/luci/luci-py/commit/7b49f6e0a9a9093f2a572d6c44e6996b992ec785
==========

[commit-bot: I haz the power, 2017-02-16 01:21:54]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/7b49f6e0a9a9093f2a572d6c44e6996b992ec785