[Offline pages] Refactoring and code fix in BackgroundOffinerTask

[Offline pages] Refactoring and code fix in BackgroundOffinerTask

This patch deals with 2 issues:
* We need to simplify the logic in BackgroundOffinerTask to reuse it
  when converting background work to JobService for O,
* It turns out that the waiter provided by ChromeBackgroundService
  was not released by the BackgroundOffinerTask in cases when device
  conditions were not met,
* Relevant test are updated: wait is added to make sure lock is
  released in all cases,
* Additionally tests are refactored to apply to new interface:
  boolean result of startBackgroundRequests was never used, hence it was
  removed and replaced with proper lock release.

BUG=690322, 683802
Review-Url: https://codereview.chromium.org/2685873003
Cr-Commit-Position: refs/heads/master@{#449502}
(cherry picked from commit 4f0be6ea9ee6b8f44a56673a26996a767fd4539c)

Review-Url: https://codereview.chromium.org/2692853011 .
Cr-Commit-Position: refs/branch-heads/2987@{#533}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d

[fgorski, 2017-02-15 22:41:06]

Description was changed from

==========
[Offline pages] Refactoring and code fix in BackgroundOffinerTask

This patch deals with 2 issues:
* We need to simplify the logic in BackgroundOffinerTask to reuse it
  when converting background work to JobService for O,
* It turns out that the waiter provided by ChromeBackgroundService
  was not released by the BackgroundOffinerTask in cases when device
  conditions were not met,
* Relevant test are updated: wait is added to make sure lock is
  released in all cases,
* Additionally tests are refactored to apply to new interface:
  boolean result of startBackgroundRequests was never used, hence it was
  removed and replaced with proper lock release.

BUG=690322,683802

Review-Url: https://codereview.chromium.org/2685873003
Cr-Commit-Position: refs/heads/master@{#449502}
(cherry picked from commit 4f0be6ea9ee6b8f44a56673a26996a767fd4539c)
==========

to

==========
[Offline pages] Refactoring and code fix in BackgroundOffinerTask

This patch deals with 2 issues:
* We need to simplify the logic in BackgroundOffinerTask to reuse it
  when converting background work to JobService for O,
* It turns out that the waiter provided by ChromeBackgroundService
  was not released by the BackgroundOffinerTask in cases when device
  conditions were not met,
* Relevant test are updated: wait is added to make sure lock is
  released in all cases,
* Additionally tests are refactored to apply to new interface:
  boolean result of startBackgroundRequests was never used, hence it was
  removed and replaced with proper lock release.

BUG=690322,683802

Review-Url: https://codereview.chromium.org/2685873003
Cr-Commit-Position: refs/heads/master@{#449502}
(cherry picked from commit 4f0be6ea9ee6b8f44a56673a26996a767fd4539c)

Review-Url: https://codereview.chromium.org/2692853011 .
Cr-Commit-Position: refs/branch-heads/2987@{#533}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/4da2d1afd4c2ca9f1d40e91e66a0...
==========

[fgorski, 2017-02-15 22:41:07]

Committed patchset #1 (id:1) manually as
4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d.