Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2692853007: Remove reference to i::JSArrayBuffer from ValueSerializer::TransferArrayBuffer comment. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove reference to i::JSArrayBuffer from ValueSerializer::TransferArrayBuffer comment. The API class is v8::ArrayBuffer; JSArrayBuffer is the internal counterpart, but its name should not appear in a public API comment. Review-Url: https://codereview.chromium.org/2692853007 Cr-Commit-Position: refs/heads/master@{#43214} Committed: https://chromium.googlesource.com/v8/v8/+/7f6b82377bb549348e10441baa583c123f319e1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
Totally trivial.
3 years, 10 months ago (2017-02-14 19:15:31 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-15 09:46:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692853007/1
3 years, 10 months ago (2017-02-15 14:22:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 14:24:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7f6b82377bb549348e10441baa583c123f3...

Powered by Google App Engine
This is Rietveld 408576698