Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java

Issue 2692853005: [Merge-57] Only record abort metrics if the Payment Request was shown. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
index a52d8ebe90a7961597f9dfce517ee316b830d489..8d619d98fbb0f1c13ca835c5af3aa0a4f927ed89 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
@@ -352,4 +352,27 @@ public class PaymentRequestJourneyLoggerTest extends PaymentRequestTestBase {
2, RecordHistogram.getHistogramValueCountForTesting(
"PaymentRequest.NumberOfSelectionEdits.ShippingAddress.Completed", 0));
}
+
+ /**
+ * Expect that no journey metrics are logged if the payment request was not shown to the user.
+ */
+ @MediumTest
+ @Feature({"Payments"})
+ public void testNoShow() throws InterruptedException, ExecutionException, TimeoutException {
+ // Android Pay is supported but no instruments are present.
+ installPaymentApp("https://android.com/pay", NO_INSTRUMENTS, DELAYED_RESPONSE);
+ openPageAndClickNodeAndWait("androidPayBuy", mShowFailed);
+ expectResultContains(new String[] {"The payment method is not supported"});
+
+ // Make sure that no journey metrics were logged.
+ assertEquals(0,
+ RecordHistogram.getHistogramValueCountForTesting(
+ "PaymentRequest.NumberOfSuggestionsShown.ShippingAddress.UserAborted", 2));
+ assertEquals(0,
+ RecordHistogram.getHistogramValueCountForTesting(
+ "PaymentRequest.NumberOfSuggestionsShown.ShippingAddress.OtherAborted", 2));
+ assertEquals(
+ 0, RecordHistogram.getHistogramValueCountForTesting(
+ "PaymentRequest.NumberOfSuggestionsShown.ShippingAddress.Completed", 2));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698