chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java - Issue 2692853005: [Merge-57] Only record abort metrics if the Payment Request was shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

Issue 2692853005: [Merge-57] Only record abort metrics if the Payment Request was shown. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

index 2cf087ed23fee3dc8b689108d6cf3402ba66031a..709855b12dbd76517f3fc3de7d7233d579c5e183 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

@@ -40,14 +40,22 @@ public final class PaymentRequestMetrics {

@VisibleForTesting

public static final int ABORT_REASON_INSTRUMENT_DETAILS_ERROR = 5;

@VisibleForTesting

- public static final int ABORT_REASON_NO_MATCHING_PAYMENT_METHOD = 6;

+ public static final int ABORT_REASON_NO_MATCHING_PAYMENT_METHOD = 6; // Deprecated.

@VisibleForTesting

- public static final int ABORT_REASON_NO_SUPPORTED_PAYMENT_METHOD = 7;

+ public static final int ABORT_REASON_NO_SUPPORTED_PAYMENT_METHOD = 7; // Deprecated.

@VisibleForTesting

public static final int ABORT_REASON_OTHER = 8;

@VisibleForTesting

public static final int ABORT_REASON_MAX = 9;

+ // PaymentRequestNoShowReason defined in tools/metrics/histograms/histograms.xml

+ @VisibleForTesting

+ public static final int NO_SHOW_NO_MATCHING_PAYMENT_METHOD = 0;

+ @VisibleForTesting

+ public static final int NO_SHOW_NO_SUPPORTED_PAYMENT_METHOD = 1;

+ @VisibleForTesting

+ public static final int NO_SHOW_REASON_MAX = 2;

// PaymentRequestPaymentMethods defined in tools/metrics/histograms/histograms.xml.

@VisibleForTesting

public static final int SELECTED_METHOD_CREDIT_CARD = 0;