Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 269283006: Update Oilpan related comment in GraphicsContext destructor. (Closed)

Created:
6 years, 7 months ago by Mads Ager (chromium)
Modified:
6 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Update Oilpan related comment in GraphicsContext destructor. I was too fast in concluding that these asserts are not interesting. There is exactly one case where they do not hold. We should reenable these asserts for the Oilpan build (but find a different way of allowing CanvasRenderingContext2D to violate them). For now, updated comment and filed a bug report to track this. R=junov@chromium.org BUG=370793 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
6 years, 7 months ago (2014-05-07 08:26:15 UTC) #1
Justin Novosad
On 2014/05/07 08:26:15, Mads Ager (chromium) wrote: lgtm Thanks. By the way, GraphicsContexts are usually ...
6 years, 7 months ago (2014-05-07 14:21:38 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 7 months ago (2014-05-07 17:32:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/269283006/1
6 years, 7 months ago (2014-05-07 17:33:06 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 18:37:30 UTC) #5
Message was sent while issue was closed.
Change committed as 173551

Powered by Google App Engine
This is Rietveld 408576698