Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: Source/platform/graphics/GraphicsContext.cpp

Issue 269283006: Update Oilpan related comment in GraphicsContext destructor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/GraphicsContext.cpp
diff --git a/Source/platform/graphics/GraphicsContext.cpp b/Source/platform/graphics/GraphicsContext.cpp
index 7124c12763c5a0536dac96b6574e54f521da817e..56a1125f250842361d1a85c67a6dd80321bbf0b3 100644
--- a/Source/platform/graphics/GraphicsContext.cpp
+++ b/Source/platform/graphics/GraphicsContext.cpp
@@ -145,11 +145,14 @@ GraphicsContext::GraphicsContext(SkCanvas* canvas, DisabledMode disableContextOr
GraphicsContext::~GraphicsContext()
{
#if !ENABLE(OILPAN)
- // These asserts are only valid in debug mode and therefore do not seem
- // useful. We cannot rely on them in any case. With Oilpan we cannot run
- // the debug mode only code in CanvasRendingContext2D's destructor which
- // touches other objects that are dead. Therefore, we disable these asserts
- // with Oilpan and should probably consider just disabling them.
+ // FIXME: Oilpan: These asserts are not true for
+ // CanvasRenderingContext2D. Therefore, there is debug mode code
+ // in the CanvasRenderingContext2D that forces this to be true so
+ // that the assertions can be here for all the other cases. With
+ // Oilpan we cannot run that code in the CanvasRenderingContext2D
+ // destructor because it touches other objects that are already
+ // dead. We need to find another way of doing these asserts when
+ // Oilpan is enabled.
ASSERT(!m_paintStateIndex);
ASSERT(!m_paintState->saveCount());
ASSERT(!m_annotationCount);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698