Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2692823002: Merged: Exposes Symbol.toPrimitive in C++ APIs as Symbol::GetToPrimitive. (Closed)

Created:
3 years, 10 months ago by Yuki
Modified:
3 years, 10 months ago
Reviewers:
hablich, Michael Hablich
CC:
Paweł Hajdan Jr., ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Exposes Symbol.toPrimitive in C++ APIs as Symbol::GetToPrimitive. Revision: 34bee46b0be6afc06f254ec0debd4b868443a649 BUG=chromium:680409 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chronium.org Review-Url: https://codereview.chromium.org/2692823002 Cr-Commit-Position: refs/branch-heads/5.7@{#98} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/d84f2b2b7ee3cb94afd1d539e5ebdbaa29e5b26c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuki
3 years, 10 months ago (2017-02-13 09:00:34 UTC) #1
Yuki
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-13 09:00:37 UTC) #2
Michael Hablich
lgtm
3 years, 10 months ago (2017-02-13 12:32:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692823002/1
3 years, 10 months ago (2017-02-13 12:34:23 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:34:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d84f2b2b7ee3cb94afd1d539e5ebdbaa29e...

Powered by Google App Engine
This is Rietveld 408576698