Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: self review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 1832dfddce5eb53fb44ef76c08eb40a8df205c42..4d24564ad303f6dcddcfa1eb2ba3fe92fcbcfcb5 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -74,6 +74,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_disable_connection_pooling);
EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier);
EXPECT_FALSE(params_.quic_enable_connection_racing);
+ EXPECT_FALSE(params_.enable_server_push_cancellation);
EXPECT_FALSE(params_.quic_enable_non_blocking_io);
EXPECT_FALSE(params_.quic_disable_disk_cache);
EXPECT_FALSE(params_.quic_prefer_aes);
@@ -210,6 +211,17 @@ TEST_F(NetworkSessionConfiguratorTest, QuicRaceCertVerification) {
EXPECT_TRUE(params_.quic_race_cert_verification);
}
+TEST_F(NetworkSessionConfiguratorTest, EnableServerPushCancellation) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["enable_server_push_cancellation"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.enable_server_push_cancellation);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicDoNotFragment) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["do_not_fragment"] = "true";

Powered by Google App Engine
This is Rietveld 408576698