Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: self review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index 91a2b15ab088b14d8e51fb39a5cd09b3d91bb4d1..fba5a01cfee0dd6e6f720fe057be82b3e5070b63 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -324,6 +324,13 @@ net::QuicVersion GetQuicVersion(const VariationParameters& quic_trial_params) {
GetVariationParam(quic_trial_params, "quic_version"));
}
+bool ShouldEnableServerPushCancelation(
+ const VariationParameters& quic_trial_params) {
+ return base::LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "enable_server_push_cancellation"),
+ "true");
+}
+
void ConfigureQuicParams(base::StringPiece quic_trial_group,
const VariationParameters& quic_trial_params,
bool is_quic_force_disabled,
@@ -335,6 +342,8 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,
is_quic_force_enabled);
params->disable_quic_on_timeout_with_open_streams =
ShouldDisableQuicWhenConnectionTimesOutWithOpenStreams(quic_trial_params);
+ params->enable_server_push_cancellation =
+ ShouldEnableServerPushCancelation(quic_trial_params);
params->enable_quic_alternative_service_with_different_host =
ShouldQuicEnableAlternativeServicesForDifferentHost(quic_trial_params);

Powered by Google App Engine
This is Rietveld 408576698