runtime/vm/intermediate_language_x64.cc - Issue 2692803006: Track the 'awaiter return' call stack use it to detect uncaught exceptions in async functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 2692803006: Track the 'awaiter return' call stack use it to detect uncaught exceptions in async functions (Closed)

Patch Set: rmacnak review Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_x64.cc

diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc

index a835e4c70419e7441e0e180cc25ab0fe0b1b1d26..0193a09ce0cc9547cff3758a81abffeb1f95d576 100644

--- a/runtime/vm/intermediate_language_x64.cc

+++ b/runtime/vm/intermediate_language_x64.cc

@@ -2546,6 +2546,7 @@ void CatchBlockEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ Bind(compiler->GetJumpLabel(this));

compiler->AddExceptionHandler(catch_try_index(), try_index(),

compiler->assembler()->CodeSize(),

+ handler_token_pos(), is_generated(),

catch_handler_types_, needs_stacktrace());

// On lazy deoptimization we patch the optimized code here to enter the

// deoptimization stub.