runtime/vm/kernel_to_il.cc - Issue 2692803006: Track the 'awaiter return' call stack use it to detect uncaught exceptions in async functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2692803006: Track the 'awaiter return' call stack use it to detect uncaught exceptions in async functions (Closed)

Patch Set: rmacnak review Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/kernel_to_il.cc

diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc

index 57a1ba3f6a6ea6cc3152564710c6f27ec93aae72..65fd9f49c09f982e7037272d2ae471a3d3fd18b2 100644

--- a/runtime/vm/kernel_to_il.cc

+++ b/runtime/vm/kernel_to_il.cc

@@ -2277,6 +2277,8 @@ Fragment FlowGraphBuilder::CatchBlockEntry(const Array& handler_types,

const bool should_restore_closure_context =

CurrentException()->is_captured() || CurrentCatchContext()->is_captured();

CatchBlockEntryInstr* entry = new (Z) CatchBlockEntryInstr(

+ TokenPosition::kNoSource, // Token position of catch block.

+ false, // Not an artifact of compilation.

AllocateBlockId(), CurrentTryIndex(), graph_entry_, handler_types,

handler_index, *CurrentException(), *CurrentStackTrace(),

/* needs_stacktrace = */ true, H.thread()->GetNextDeoptId(),