Avoid checking family name in getLastResortFallbackFont() on Windows

Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. FontCache checks if the family name of the SkTypeface returned
from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
Review-Url: https://codereview.chromium.org/2692803005
Cr-Commit-Position: refs/heads/master@{#450372}
Committed: https://chromium.googlesource.com/chromium/src/+/ff7fede033b10623c7085324f7e02cf338478f40

[kojii, 2017-02-14 07:00:50]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 07:01:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-14 07:17:42]

Description was changed from

==========
AlternateFontName

BUG=
==========

to

==========
Avoid checking family name in getLastResortFallbackFont()

Windows can return a valid SkTypeface even when requested name does not
exist. In normal case, FontCache checks if the family name of the
SkTypeface returned from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

[kojii, 2017-02-14 07:18:31]

Description was changed from

==========
Avoid checking family name in getLastResortFallbackFont()

Windows can return a valid SkTypeface even when requested name does not
exist. In normal case, FontCache checks if the family name of the
SkTypeface returned from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

to

==========
Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. In normal case, FontCache checks if the family name of the
SkTypeface returned from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

[kojii, 2017-02-14 07:29:29]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 07:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-14 07:30:10]

Description was changed from

==========
Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. In normal case, FontCache checks if the family name of the
SkTypeface returned from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

to

==========
Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. FontCache checks if the family name of the SkTypeface returned
from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

[kojii, 2017-02-14 07:30:24]

Patchset #1 (id:1) has been deleted

[kojii, 2017-02-14 08:16:51]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 08:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-14 08:20:50]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-14 11:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:11:09]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-02-14 14:13:30]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-02-14 14:13:31]

PTAL. WDYT? The stability sheriff reminded me to work on this.

Our last guesstimate is the cause is somewhere in Blink, so reduce/CHECK/UMA all
where we return nullptr might be one way to go.

This one might not be likely, but impact should be small, and passing a flag
down will help adding more checks for when last resort font is requested.

[eae, 2017-02-14 15:50:19]

Let's try it, thank you

LGTM

[eae, 2017-02-14 16:04:41]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:05:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 16:09:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487088281167360,
"parent_rev": "3aac9a6f4949e33dfe3045326ce6afda6293667d", "commit_rev":
"ff7fede033b10623c7085324f7e02cf338478f40"}

[commit-bot: I haz the power, 2017-02-14 16:10:29]

Description was changed from

==========
Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. FontCache checks if the family name of the SkTypeface returned
from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873
==========

to

==========
Avoid checking family name in getLastResortFallbackFont() on Windows

Windows can return a valid SkTypeface even when requested name does not
exist. FontCache checks if the family name of the SkTypeface returned
from Skia matches to the requested name.

This patch disables the check in getLastResortFallbackFont(). In this
case, finding a font is more important than finding the font with the
requested family name.

This change eliminates one possible case where
getLastResortFallbackFont() can return nullptr on Windows.

BUG=561873

Review-Url: https://codereview.chromium.org/2692803005
Cr-Commit-Position: refs/heads/master@{#450372}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff7fede033b10623c7085324f7e0...
==========

[commit-bot: I haz the power, 2017-02-14 16:10:30]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff7fede033b10623c7085324f7e0...