Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2692803003: Remove webkit prefixes for CSS Animation in ui/ styles (Closed)

Created:
3 years, 10 months ago by Eric Willigers
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, fukino+watch_chromium.org, mtomasz+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove webkit prefixes for CSS Animation in ui/ styles Animation properties, events and keyframes no longer require webkit prefix. BUG=668650 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2692803003 Cr-Commit-Position: refs/heads/master@{#450252} Committed: https://chromium.googlesource.com/chromium/src/+/92e6e5567554bc1bcb75e6e90abb522c0aae85de

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -109 lines) Patch
M ui/accessibility/extensions/alt/hide-images.css View 4 chunks +15 lines, -16 lines 1 comment Download
M ui/file_manager/file_manager/foreground/css/common.css View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 9 chunks +11 lines, -11 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html View 1 2 chunks +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 1 4 chunks +12 lines, -12 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 5 chunks +9 lines, -9 lines 0 comments Download
M ui/webui/resources/css/dialogs.css View 1 2 chunks +9 lines, -9 lines 0 comments Download
M ui/webui/resources/css/overlay.css View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/webui/resources/images/throbber_medium.svg View 1 4 chunks +14 lines, -14 lines 0 comments Download
M ui/webui/resources/images/throbber_small.svg View 1 4 chunks +14 lines, -14 lines 0 comments Download
M ui/webui/resources/js/cr/ui/overlay.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
Eric Willigers
3 years, 10 months ago (2017-02-13 23:03:05 UTC) #8
Dan Beam
lgtm https://codereview.chromium.org/2692803003/diff/20001/ui/accessibility/extensions/alt/hide-images.css File ui/accessibility/extensions/alt/hide-images.css (left): https://codereview.chromium.org/2692803003/diff/20001/ui/accessibility/extensions/alt/hide-images.css#oldcode79 ui/accessibility/extensions/alt/hide-images.css:79: box-shadow: 0 0 5px black; lol
3 years, 10 months ago (2017-02-14 02:36:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692803003/20001
3 years, 10 months ago (2017-02-14 02:38:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/363527)
3 years, 10 months ago (2017-02-14 02:48:35 UTC) #17
Eric Willigers
+sky for accessibility and file_manager OWNERS
3 years, 10 months ago (2017-02-14 02:56:40 UTC) #19
sky
LGTM
3 years, 10 months ago (2017-02-14 04:16:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692803003/20001
3 years, 10 months ago (2017-02-14 04:44:20 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 04:49:56 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92e6e5567554bc1bcb75e6e90abb...

Powered by Google App Engine
This is Rietveld 408576698