Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2692793007: cros: Move DemoModeDetector out of webui directory. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move DemoModeDetector out of webui directory. TBR=pam@chromium.org BUG=672142 Review-Url: https://codereview.chromium.org/2692793007 Cr-Commit-Position: refs/heads/master@{#450763} Committed: https://chromium.googlesource.com/chromium/src/+/59d6f53d51032a8b4b4568e2af635b21bd754f88

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -261 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/demo_mode/demo_mode_detector.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/login/demo_mode/demo_mode_detector.cc View 5 chunks +14 lines, -25 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/webui/chromeos/login/demo_mode_detector.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc View 1 chunk +0 lines, -161 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (17 generated)
jdufault
alemate@ PTAL. No functional changes.
3 years, 10 months ago (2017-02-15 18:36:38 UTC) #12
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-15 18:51:26 UTC) #13
jdufault
TBR=pam@ for trivial change in browser_prefs.cc
3 years, 10 months ago (2017-02-15 18:53:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692793007/20001
3 years, 10 months ago (2017-02-15 18:54:14 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:20:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59d6f53d51032a8b4b4568e2af63...

Powered by Google App Engine
This is Rietveld 408576698