Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4217)

Unified Diff: ash/common/wm/overview/window_selector_item.cc

Issue 2692663002: Gut ash::MaterialDesignController, and remove the about:flags entry. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/window_selector_item.cc
diff --git a/ash/common/wm/overview/window_selector_item.cc b/ash/common/wm/overview/window_selector_item.cc
index 09bc82556549e4fc773e01c52e11988da0b33210..207a4ec6b390182b2e91562062d60b562acd46ed 100644
--- a/ash/common/wm/overview/window_selector_item.cc
+++ b/ash/common/wm/overview/window_selector_item.cc
@@ -673,13 +673,12 @@ void WindowSelectorItem::CreateWindowLabel(const base::string16& title) {
// Note: current shadow implementation does not allow proper animation when
// the parent layer bounds change during the animation since
// Shadow::UpdateLayerBounds() only happens before the animation starts.
- if (ash::MaterialDesignController::GetMode() ==
- ash::MaterialDesignController::Mode::MATERIAL_EXPERIMENTAL) {
- shadow_.reset(new ::wm::Shadow());
- shadow_->Init(::wm::ShadowElevation::MEDIUM);
- shadow_->layer()->SetVisible(true);
- item_widget_->GetLayer()->Add(shadow_->layer());
- }
+#if 0
tdanderson 2017/02/13 17:36:28 Just delete this code instead.
Evan Stade 2017/02/13 17:41:01 there's other related code throughout this file (b
varkha 2017/02/13 17:44:01 Yes, please go ahead. The shadow was barely visibl
Evan Stade 2017/02/13 17:52:24 indeed, it was supposed to be there for Alt+Tab to
Evan Stade 2017/02/13 19:29:42 Done.
+ shadow_.reset(new ::wm::Shadow());
+ shadow_->Init(::wm::ShadowElevation::MEDIUM);
+ shadow_->layer()->SetVisible(true);
+ item_widget_->GetLayer()->Add(shadow_->layer());
+#endif
item_widget_->GetLayer()->SetMasksToBounds(false);
}

Powered by Google App Engine
This is Rietveld 408576698