[Devtools] Added Enable/Disable for request blocking in network

third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 675 matching lines @@
     super();
 
     /** @type {!Set<string>} */
     this._blockedURLs = new Set();
     this._blockedSetting = Common.moduleSetting('networkBlockedURLs');
     this._blockedSetting.addChangeListener(this._updateBlockedURLs, this);
     this._blockedSetting.set([]);
     this._updateBlockedURLs();
 
     this._userAgentOverride = '';
+    this._isRequestBlockingEnabled = false;
     /** @type {!Set<!Protocol.NetworkAgent>} */
     this._agents = new Set();
     /** @type {!SDK.NetworkManager.Conditions} */
     this._networkConditions = SDK.NetworkManager.NoThrottlingConditions;
 
     SDK.targetManager.observeTargets(this, SDK.Target.Capability.Network);
   }
 
   /**
    * @param {string} uaString
@@ skipping 139 matching lines @@
       if (blocked.indexOf(url) === -1)
         this._removeBlockedURL(url);
     }
   }
 
   /**
    * @param {string} url
    */
   _addBlockedURL(url) {
     this._blockedURLs.add(url);
+    if (!this._isRequestBlockingEnabled)
+      return;
     for (var agent of this._agents)
       agent.addBlockedURL(url);
   }
 
   /**
    * @param {string} url
    */
   _removeBlockedURL(url) {
     this._blockedURLs.delete(url);
+    if (!this._isRequestBlockingEnabled)
+      return;
     for (var agent of this._agents)
       agent.removeBlockedURL(url);
   }
 
+  /**
+   * @param {boolean} enabled
+   */
+  setRequestBlockingEnabled(enabled) {
+    if (this._isRequestBlockingEnabled === enabled)
+      return;
+    this._isRequestBlockingEnabled = enabled;
+    if (enabled) {
+      for (var agent of this._agents)
+        this._blockedURLs.forEach(url => agent.addBlockedURL(url));

[pfeldman, 2017/02/13 18:24:26]

Let's follow up immediately with converting add/removeBlockedURL to
setBlockedURLs.

[allada, 2017/02/16 21:42:03]

Done. see: https://codereview.chromium.org/2703603003

+    } else {
+      for (var agent of this._agents)
+        this._blockedURLs.forEach(url => agent.removeBlockedURL(url));
+    }
+    this.emit(new SDK.MultitargetNetworkManager.RequestBlockingEnabledChangedEvent(enabled));
+  }
+
+  isRequestBlockingEnabled() {
+    return this._isRequestBlockingEnabled;
+  }
+
   clearBrowserCache() {
     for (var agent of this._agents)
       agent.clearBrowserCache();
   }
 
   clearBrowserCookies() {
     for (var agent of this._agents)
       agent.clearBrowserCookies();
   }
 
@@ skipping 31 matching lines @@
     Host.ResourceLoader.load(url, headers, callback);
   }
 };
 
 /** @enum {symbol} */
 SDK.MultitargetNetworkManager.Events = {
   ConditionsChanged: Symbol('ConditionsChanged'),
   UserAgentChanged: Symbol('UserAgentChanged')
 };
 
+/** @implements {Common.Emittable} */
+SDK.MultitargetNetworkManager.RequestBlockingEnabledChangedEvent = class {

[pfeldman, 2017/02/13 18:24:26]

Seems like a lot of boilerplate for a simple listener. How about pass nothing in
the event, use old events and expose requestBlockingEnabled() ?

[allada, 2017/02/16 21:42:03]

How about this as a compromise.

+  /**
+   * @param {boolean} enabled
+   */
+  constructor(enabled) {
+    this.enabled = enabled;
+  }
+};
 
 /**
  * @type {!SDK.MultitargetNetworkManager}
  */
 SDK.multitargetNetworkManager;