Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2692563002: Merged: [wasm] Accept version 0x1 binaries. (Closed)

Created:
3 years, 10 months ago by titzer
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [wasm] Accept version 0x1 binaries. Revision: fa7d1f8f75e340d917831ef74f401154b0a90cc7 BUG=chromium:575167, chromium:690281 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bradnelson@chromium.org, hablich@chromium.org Review-Url: https://codereview.chromium.org/2692563002 Cr-Commit-Position: refs/branch-heads/5.7@{#96} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/208c1202a1941e95e3fa70fc1d9c40644d67f989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/inspector/debugger/wasm-scripts-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/incrementer.wasm View Binary file 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
3 years, 10 months ago (2017-02-10 19:30:33 UTC) #1
titzer
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-10 19:30:35 UTC) #2
bradnelson
lgtm
3 years, 10 months ago (2017-02-10 20:26:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692563002/1
3 years, 10 months ago (2017-02-10 21:30:18 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 21:30:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/208c1202a1941e95e3fa70fc1d9c40644d6...

Powered by Google App Engine
This is Rietveld 408576698