Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2692553002: Remove the methods of EditingStyle class moved to EditingStyleUtilities class (Closed)

Created:
3 years, 10 months ago by joone
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the methods of EditingStyle class moved to EditingStyleUtilities class EditingStyle is used to deal with CSS styles in editing. but it has many static methods to create an EditingStyle and some methods don't access member variables so they could be split into EditingStyleUtilities class. In the previous CLs, we copied EditingStyle class and renamed it to EditingStyleUtilities class(https://crrev.com/2649613002). Then, we only kept the static methods used to create an EditingStyle and some static methods for utility purpose in EditingStyleUtilities class(https://crrev.com/2685783004). In addition, we renamed the methods in EditingStyleUtilities class and make them used in editing(https://crrev.com/2687243002). This CL gets rid of the static methods moved to EditingStyleUtilities class from EditiingStyle class. BUG=679817 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2692553002 Cr-Commit-Position: refs/heads/master@{#449913} Committed: https://chromium.googlesource.com/chromium/src/+/ae8ce8f3f082cbb2a2e71f86a78a506cb231c606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -284 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.h View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 5 chunks +0 lines, -268 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
joone
Hi yosin@ this is the final CL for EditingStyleUtilities class. Thanks!
3 years, 10 months ago (2017-02-10 21:43:52 UTC) #6
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-13 03:17:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692553002/1
3 years, 10 months ago (2017-02-13 03:17:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/320179)
3 years, 10 months ago (2017-02-13 03:18:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692553002/1
3 years, 10 months ago (2017-02-13 05:34:24 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 05:53:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae8ce8f3f082cbb2a2e71f86a78a...

Powered by Google App Engine
This is Rietveld 408576698