Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2692533002: [Chromedriver] Disable window & screenshot tests on Chrome v57. (Closed)

Created:
3 years, 10 months ago by gmanikpure
Modified:
3 years, 10 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Disable window & screenshot tests on Chrome v57. BUG=chromedriver:1625 Review-Url: https://codereview.chromium.org/2692533002 Cr-Commit-Position: refs/heads/master@{#449693} Committed: https://chromium.googlesource.com/chromium/src/+/ed8f1828942b62be160096076aef279b1367f2bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/test/test_expectations View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gmanikpure
Sam, After advancing bot to M57, tests that are already disabled on HEAD started failing ...
3 years, 10 months ago (2017-02-10 18:29:03 UTC) #2
samuong
lgtm
3 years, 10 months ago (2017-02-10 18:38:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692533002/1
3 years, 10 months ago (2017-02-10 18:40:05 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:39:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed8f1828942b62be160096076aef...

Powered by Google App Engine
This is Rietveld 408576698