Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2692493002: cc: Fix flaky scroll animation test (Closed)

Created:
3 years, 10 months ago by ajuma
Modified:
3 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix flaky scroll animation test This fixes LayerTreeHostAnimationTestScrollOffsetAnimationAdjusted by removing an expectation that depends on the ordering of the first draw and the second commit, and isn't actually needed for what's being tested. BUG=690584 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2692493002 Cr-Commit-Position: refs/heads/master@{#449665} Committed: https://chromium.googlesource.com/chromium/src/+/a446224d4d9f2ffd3b0598d5c7647c886890a8ce

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 14 (10 generated)
ajuma
https://codereview.chromium.org/2692493002/diff/1/cc/trees/layer_tree_host_unittest_animation.cc File cc/trees/layer_tree_host_unittest_animation.cc (left): https://codereview.chromium.org/2692493002/diff/1/cc/trees/layer_tree_host_unittest_animation.cc#oldcode898 cc/trees/layer_tree_host_unittest_animation.cc:898: EXPECT_EQ(Animation::RunState::RUNNING, animation->run_state()); This will be STARTING if the first ...
3 years, 10 months ago (2017-02-10 16:19:05 UTC) #6
danakj
LGTM thanks!
3 years, 10 months ago (2017-02-10 16:33:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692493002/1
3 years, 10 months ago (2017-02-10 18:23:53 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 18:31:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a446224d4d9f2ffd3b0598d5c764...

Powered by Google App Engine
This is Rietveld 408576698