Issue 2692453002: Specify orphans:1 and widows:1 in old multicol test.

Issue 2692453002: Specify orphans:1 and widows:1 in old multicol test. (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)

Modified:
3 years, 10 months ago

Reviewers:
rune

CC:
chromium-reviews, blink-reviews, mstensho (USE GERRIT)

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Specify orphans:1 and widows:1 in old multicol test. The test and the ref rendered identically, but it didn't look as asserted by the textual pass condition. Review-Url: https://codereview.chromium.org/2692453002 Cr-Commit-Position: refs/heads/master@{#449637} Committed: https://chromium.googlesource.com/chromium/src/+/92cc21d5ffc4ec09b826a0931a57c89baedc1861

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	third_party/WebKit/LayoutTests/fast/multicol/span/spanner-img.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/LayoutTests/fast/multicol/span/spanner-img-expected.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (4 generated)

mstensho (USE GERRIT)

This used to render correctly, until we started to give orphans and widows the initial ...

3 years, 10 months ago (2017-02-10 13:43:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692453002/1

3 years, 10 months ago (2017-02-10 15:56:02 UTC) #5

commit-bot: I haz the power

3 years, 10 months ago (2017-02-10 16:59:48 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92cc21d5ffc4ec09b826a0931a57...