Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2692413002: Implements mojo::StrongBindingSet. (Closed)

Created:
3 years, 10 months ago by alokp
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements mojo::StrongBindingSet. Review-Url: https://codereview.chromium.org/2692413002 Cr-Commit-Position: refs/heads/master@{#450631} Committed: https://chromium.googlesource.com/chromium/src/+/363e6ab2daf14159f94823b004b23e7cc1619728

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -15 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/associated_binding_set.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/binding_set.h View 6 chunks +19 lines, -13 lines 0 comments Download
A mojo/public/cpp/bindings/strong_binding_set.h View 1 chunk +26 lines, -0 lines 2 comments Download
M mojo/public/cpp/bindings/tests/binding_set_unittest.cc View 2 chunks +62 lines, -0 lines 2 comments Download
A mojo/public/cpp/bindings/unique_ptr_impl_ref_traits.h View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alokp
xhwang@: If you do not have any objections, I can replace media::StrongBindingSet with this one ...
3 years, 10 months ago (2017-02-15 05:42:45 UTC) #2
Ken Rockot(use gerrit already)
Lgtm - thanks for doing this!
3 years, 10 months ago (2017-02-15 06:23:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692413002/1
3 years, 10 months ago (2017-02-15 06:28:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/363e6ab2daf14159f94823b004b23e7cc1619728
3 years, 10 months ago (2017-02-15 07:53:44 UTC) #8
xhwang
Thanks for the patch! Sorry I have some late comments, but mostly nits. Yes, it'll ...
3 years, 10 months ago (2017-02-16 03:54:50 UTC) #9
xhwang
https://codereview.chromium.org/2692413002/diff/1/mojo/public/cpp/bindings/strong_binding_set.h File mojo/public/cpp/bindings/strong_binding_set.h (right): https://codereview.chromium.org/2692413002/diff/1/mojo/public/cpp/bindings/strong_binding_set.h#newcode18 mojo/public/cpp/bindings/strong_binding_set.h:18: template <typename Interface, typename ContextType = void> On 2017/02/16 ...
3 years, 10 months ago (2017-02-16 04:03:07 UTC) #10
alokp
https://codereview.chromium.org/2692413002/diff/1/mojo/public/cpp/bindings/tests/binding_set_unittest.cc File mojo/public/cpp/bindings/tests/binding_set_unittest.cc (right): https://codereview.chromium.org/2692413002/diff/1/mojo/public/cpp/bindings/tests/binding_set_unittest.cc#newcode411 mojo/public/cpp/bindings/tests/binding_set_unittest.cc:411: EXPECT_EQ(0, PingInstanceCounter::instance_count); On 2017/02/16 03:54:49, xhwang_slow wrote: > What ...
3 years, 10 months ago (2017-02-16 04:42:47 UTC) #11
Ken Rockot(use gerrit already)
3 years, 10 months ago (2017-02-16 04:44:20 UTC) #12
Message was sent while issue was closed.
On Wed, Feb 15, 2017 at 8:42 PM, <alokp@chromium.org> wrote:

>
> https://codereview.chromium.org/2692413002/diff/1/mojo/
> public/cpp/bindings/tests/binding_set_unittest.cc
> File mojo/public/cpp/bindings/tests/binding_set_unittest.cc (right):
>
> https://codereview.chromium.org/2692413002/diff/1/mojo/
> public/cpp/bindings/tests/binding_set_unittest.cc#newcode411
> mojo/public/cpp/bindings/tests/binding_set_unittest.cc:411: EXPECT_EQ(0,
> PingInstanceCounter::instance_count);
> On 2017/02/16 03:54:49, xhwang_slow wrote:
> > What happens if you call RemoveBinding with a random/invalid binding
> ID?
>
> That would be a test for any BindingSet derived from BindingSetBase.
> Removing an invalid binding id is not related specifically to
> StrongBindingSet. I guess we need some type-parametrized tests.
>

Is this really worth unit testing? The implementation is trivial.


>
> https://github.com/google/googletest/blob/master/
> googletest/docs/AdvancedGuide.md#type-parameterized-tests
>
> https://codereview.chromium.org/2692413002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698