Put the new harmonized dialog implementation behind flag.

Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG=680381
Review-Url: https://codereview.chromium.org/2692403002
Cr-Commit-Position: refs/heads/master@{#450746}
Committed: https://chromium.googlesource.com/chromium/src/+/b403d81b96c9dd5a244bae996dc65ca22ee9df4d

[xdai1, 2017-02-15 01:43:35]

Description was changed from

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md
2) Remove the padding to its right "eye" button
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as seen in
pre-harmonized dialogs).

BUG=680381
==========

to

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as seen in
pre-harmonized dialogs).

BUG=680381
==========

[xdai1, 2017-02-15 01:46:09]

xdai@chromium.org changed reviewers:
+ stevenjb@chromium.org

[xdai1, 2017-02-15 01:46:09]

stevenjb@, could you help review this CL please? I'll follow up with the
designer to get the latest mock of the WiFi dialogs (per pkasting@'s suggestion
in the bug comment, these mocks seems out-dated). Thanks!

https://codereview.chromium.org/2692403002/diff/1/chrome/browser/chromeos/opt...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

https://codereview.chromium.org/2692403002/diff/1/chrome/browser/chromeos/opt...
chrome/browser/chromeos/options/wifi_config_view.cc:949: const int
kLabelMinWidth = 158;
This value increased a little bit because we removed the padding to the right of
the "eye" button.

[xdai1, 2017-02-15 01:46:17]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 01:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-02-15 01:56:03]

Honestly, this level of effort and review is what I was hoping to avoid. I am
going to RS lgtm this and hope for the best...

[commit-bot: I haz the power, 2017-02-15 03:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 03:45:28]

Dry run: This issue passed the CQ dry run.

[xdai1, 2017-02-15 17:56:26]

Description was changed from

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as seen in
pre-harmonized dialogs).

BUG=680381
==========

to

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG=680381
==========

[xdai1, 2017-02-15 18:03:04]

On 2017/02/15 01:56:03, stevenjb wrote:
> Honestly, this level of effort and review is what I was hoping to avoid. I am
> going to RS lgtm this and hope for the best...

Thanks! I also hope this is the last CL related to harmonized connectivity
dialogs. I won't proactively work on this any more unless there are bugs coming
in.

[xdai1, 2017-02-15 18:03:24]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2017-02-15 18:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 18:50:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487181804363250, "parent_rev":
"642fb6276fe309082636d5a8b197a26357b63f03", "commit_rev":
"b403d81b96c9dd5a244bae996dc65ca22ee9df4d"}

[commit-bot: I haz the power, 2017-02-15 18:51:35]

Description was changed from

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG=680381
==========

to

==========
Put the new harmonized dialog implementation behind flag.

This CL does the following:
1) Put the harmony work behind the flag --secondary-ui-md so
   nothing is changed for pre-harmony dialogs.
2) Remove the padding to its right "eye" button.
3) For harmonized dialog, the size of the dialog is calculated by its
client view, not from the pre-determined values (as for pre-harmonized dialogs).

BUG=680381

Review-Url: https://codereview.chromium.org/2692403002
Cr-Commit-Position: refs/heads/master@{#450746}
Committed:
https://chromium.googlesource.com/chromium/src/+/b403d81b96c9dd5a244bae996dc6...
==========

[commit-bot: I haz the power, 2017-02-15 18:51:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b403d81b96c9dd5a244bae996dc6...