Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2692393002: Tab/Desktop capture: Fix for super-old frame after resume. (Closed)

Created:
3 years, 10 months ago by miu
Modified:
3 years, 10 months ago
Reviewers:
xjz
CC:
chromium-reviews, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tab/Desktop capture: Fix for super-old frame after resume. After a Resume() operation, set a flag that will force the next frame refresh operation to be of the "active" kind (i.e., actually execute a capture of the current screen) rather than the "passive" kind (i.e., pull the last frame back out of the buffer pool). This will ensure that, since the screen may have changed during the Suspend(), the next frame emitted contains the most up-to-date content. BUG=692261, 650113 Review-Url: https://codereview.chromium.org/2692393002 Cr-Commit-Position: refs/heads/master@{#450575} Committed: https://chromium.googlesource.com/chromium/src/+/7239bff66dcb73541208ba0924470f5e74dad72a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M media/capture/content/screen_capture_device_core.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/capture/content/screen_capture_device_core.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
miu
xjz: PTAL.
3 years, 10 months ago (2017-02-15 00:47:36 UTC) #2
xjz
lgtm
3 years, 10 months ago (2017-02-15 01:23:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692393002/1
3 years, 10 months ago (2017-02-15 02:25:15 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 05:57:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7239bff66dcb73541208ba092447...

Powered by Google App Engine
This is Rietveld 408576698