Disable virtual/android/fullscreen/full-screen-iframe-zIndex.html

Disable virtual/android/fullscreen/full-screen-iframe-zIndex.html

The test currently passes, but fails when the feature "Stop creating layout
objects for elements inside display: none iframes" is enabled. The root cause is
a long-standing fullscreen issue, see minimized repro in crbug.com/676432. The
issue is likely going to go away with "migrate fullscreen to use top layer".

BUG=676432, 650433, 240576
Review-Url: https://codereview.chromium.org/2692363002
Cr-Commit-Position: refs/heads/master@{#450626}
Committed: https://chromium.googlesource.com/chromium/src/+/c715c5116fb070cf376342de9bc67bc7dbfea23d

[erikchen, 2017-02-14 22:40:46]

erikchen@chromium.org changed reviewers:
+ esprehn@chromium.org, foolip@chromium.org

[erikchen, 2017-02-14 22:40:46]

esprehn, foolip: Please review.

This CL is a carbon copy of https://codereview.chromium.org/2662453002/, but
with virtual/android/fullscreen/full-screen-iframe-zIndex.html instead of
fullscreen/full-screen-iframe-zIndex.htm.

[erikchen, 2017-02-14 22:40:49]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 22:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:49:45]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-02-15 01:38:10]

lgtm

[erikchen, 2017-02-15 01:41:49]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-02-15 01:43:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 05:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 05:25:03]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:2304
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
ea55aba471b316e088ab7a3bf2f795511a452943..72fa906cd57b6e67b55f03928c0562c0d809200a
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -751,6 +751,7 @@ crbug.com/567837 fast/hidpi/static [ Skip ]
 # future, as foolip@ is in the process of performing a significant fullscreen
 # refactor. See [crbug.com/676432] for a minimized repro.
 crbug.com/676432 fullscreen/full-screen-iframe-zIndex.html [ Skip ]
+crbug.com/676432 virtual/android/fullscreen/full-screen-iframe-zIndex.html [
Skip ]
 
 # TODO(xiaochengh): We should either convert the following tests with
 # spellcheck_test, or remove if they become redundant or inapplicable.
@@ -2304,4 +2305,4 @@ crbug.com/688486
external/wpt/service-workers/service-worker/fetch-request-resou
 crbug.com/688515 [ Linux ] http/tests/media/video-play-stall.html [ Pass
Failure ]
 
 # Sheriff failures Feb 13 2017
-crbug.com/691423 [ Mac ] fast/frames/location-change-no-file-access.html [
Failure Pass ]
\ No newline at end of file
+crbug.com/691423 [ Mac ] fast/frames/location-change-no-file-access.html [
Failure Pass ]

[foolip, 2017-02-15 05:51:49]

On 2017/02/14 22:40:46, erikchen wrote:
> esprehn, foolip: Please review.
> 
> This CL is a carbon copy of https://codereview.chromium.org/2662453002/, but
> with virtual/android/fullscreen/full-screen-iframe-zIndex.html instead of
> fullscreen/full-screen-iframe-zIndex.htm.

lgtm

[erikchen, 2017-02-15 06:21:37]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-02-15 06:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2692363002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-02-15 06:22:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 07:41:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487139697744680,
"parent_rev": "7b9838f84b0aef41622e9468ded89d0e52a3280f", "commit_rev":
"c715c5116fb070cf376342de9bc67bc7dbfea23d"}

[commit-bot: I haz the power, 2017-02-15 07:41:50]

Description was changed from

==========
Disable virtual/android/fullscreen/full-screen-iframe-zIndex.html

The test currently passes, but fails when the feature "Stop creating layout
objects for elements inside display: none iframes" is enabled. The root cause is
a long-standing fullscreen issue, see minimized repro in crbug.com/676432. The
issue is likely going to go away with "migrate fullscreen to use top layer".

BUG=676432, 650433, 240576
==========

to

==========
Disable virtual/android/fullscreen/full-screen-iframe-zIndex.html

The test currently passes, but fails when the feature "Stop creating layout
objects for elements inside display: none iframes" is enabled. The root cause is
a long-standing fullscreen issue, see minimized repro in crbug.com/676432. The
issue is likely going to go away with "migrate fullscreen to use top layer".

BUG=676432, 650433, 240576

Review-Url: https://codereview.chromium.org/2692363002
Cr-Commit-Position: refs/heads/master@{#450626}
Committed:
https://chromium.googlesource.com/chromium/src/+/c715c5116fb070cf376342de9bc6...
==========

[commit-bot: I haz the power, 2017-02-15 07:41:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c715c5116fb070cf376342de9bc6...