Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2692333004: [Presentation API] Adds UseCounters for origin types. (Closed)

Created:
3 years, 10 months ago by mark a. foltz
Modified:
3 years, 10 months ago
Reviewers:
haraken, zhaobin
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] Adds UseCounters. This adds UseCounters for secure and insecure contexts when using the Presentation API. This is in preparation for deprecating the API on insecure contexts. BUG=692185 Review-Url: https://codereview.chromium.org/2692333004 Cr-Commit-Position: refs/heads/master@{#450994} Committed: https://chromium.googlesource.com/chromium/src/+/d35f8c61ab3d89a4fe0f6de3e641d1748dc5ef09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/Presentation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiver.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp View 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 chunk +15 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mark a. foltz
3 years, 10 months ago (2017-02-16 08:03:03 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-16 08:11:36 UTC) #6
zhaobin
lgtm
3 years, 10 months ago (2017-02-16 08:19:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692333004/1
3 years, 10 months ago (2017-02-16 16:45:59 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 16:57:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d35f8c61ab3d89a4fe0f6de3e641...

Powered by Google App Engine
This is Rietveld 408576698