Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692313003:
Enable Purge+throttle by default except Android and MacOS. (Closed)
DescriptionEnable Purge+throttle by default except Android and MacOS.
purge+throttle is lgtm-ed:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
The finch result is:
https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9XxlI/edit?usp=sharing
BUG=635419
Review-Url: https://codereview.chromium.org/2692313003
Cr-Commit-Position: refs/heads/master@{#460726}
Committed: https://chromium.googlesource.com/chromium/src/+/e504e898649ac4eb5d9bbf371dd4e6c57034cb19
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added comment. #Messages
Total messages: 26 (17 generated)
The CQ bit was checked by tasak@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Enable Purge+throttle by default except Android and MacOS. BUG=635419 ========== to ========== Enable Purge+throttle by default except Android and MacOS. purge+throttle is lgtm-ed: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 BUG=635419 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by tasak@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable Purge+throttle by default except Android and MacOS. purge+throttle is lgtm-ed: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 BUG=635419 ========== to ========== Enable Purge+throttle by default except Android and MacOS. purge+throttle is lgtm-ed: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 The finch result is: https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9Xx... BUG=635419 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tasak@google.com changed reviewers: + avi@chromium.org, haraken@chromium.org
Would you review this CL?
LGTM Also there was some follow-up discussion on chrome-speed@google.com and now people on that thread have agreed on shipping this.
lgtm 🎉
wez@chromium.org changed reviewers: + wez@chromium.org
https://codereview.chromium.org/2692313003/diff/20001/content/public/common/c... File content/public/common/content_features.cc (right): https://codereview.chromium.org/2692313003/diff/20001/content/public/common/c... content/public/common/content_features.cc:156: #if defined(OS_MACOSX) || defined(OS_ANDROID) Is there a bug with context on why we don't enable this for Mac OS, that you could add a comment to link to here?
Thank you for review. https://codereview.chromium.org/2692313003/diff/20001/content/public/common/c... File content/public/common/content_features.cc (right): https://codereview.chromium.org/2692313003/diff/20001/content/public/common/c... content/public/common/content_features.cc:156: #if defined(OS_MACOSX) || defined(OS_ANDROID) On 2017/03/29 23:50:55, Wez wrote: > Is there a bug with context on why we don't enable this for Mac OS, that you > could add a comment to link to here? Added. So this comment looks ok?
lgtm
The CQ bit was checked by tasak@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/2692313003/#ps40001 (title: "Added comment.")
On 2017/03/30 09:39:51, Wez wrote: > lgtm Thank you.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490871471879310,
"parent_rev": "28a45cda9497b44af350076f427695fb98ef6bd6", "commit_rev":
"e504e898649ac4eb5d9bbf371dd4e6c57034cb19"}
Message was sent while issue was closed.
Description was changed from ========== Enable Purge+throttle by default except Android and MacOS. purge+throttle is lgtm-ed: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 The finch result is: https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9Xx... BUG=635419 ========== to ========== Enable Purge+throttle by default except Android and MacOS. purge+throttle is lgtm-ed: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 The finch result is: https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9Xx... BUG=635419 Review-Url: https://codereview.chromium.org/2692313003 Cr-Commit-Position: refs/heads/master@{#460726} Committed: https://chromium.googlesource.com/chromium/src/+/e504e898649ac4eb5d9bbf371dd4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e504e898649ac4eb5d9bbf371dd4... |
