Hacky slashy

Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp third_party/fuchsia-sdk/toolchain_libs/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2' --check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

[scottmg, 2017-02-16 20:29:56]

Description was changed from

==========
Port of base to Fuchsia

XXX Prototype only.
==========

to

==========
Port of base to Fuchsia

XXX Prototype only.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[scottmg, 2017-02-16 20:38:12]

Description was changed from

==========
Port of base to Fuchsia

XXX Prototype only.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Port of base to Fuchsia

XXX Prototype only.
==========

[scottmg, 2017-02-16 20:41:08]

Description was changed from

==========
Port of base to Fuchsia

XXX Prototype only.
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.
==========

[cpu_(ooo_6.6-7.5), 2017-02-16 20:54:36]

cpu@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2017-02-16 20:54:36]

I expected to look worse :)

I think we have libxml, let me check.

[jochen (gone - plz use gerrit), 2017-02-16 20:58:59]

On 2017/02/16 at 20:54:36, cpu wrote:
> I expected to look worse :)
> 
> I think we have libxml, let me check.

What's missing for v8?

[scottmg, 2017-02-16 21:19:55]

On 2017/02/16 20:58:59, jochen wrote:
> On 2017/02/16 at 20:54:36, cpu wrote:
> > I expected to look worse :)
> > 
> > I think we have libxml, let me check.
> 
> What's missing for v8?

Not really that much I think, I was just going to start with base/ to see how
invasive it is.

[scottmg, 2017-02-16 22:25:32]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.

gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check
==========

[scottmg, 2017-02-16 22:26:58]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.

gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests

Currently gets as far as failing link lacking, well, the implementation for most
of base.
==========

[scottmg, 2017-02-16 22:27:12]

Patchset #2 (id:20001) has been deleted

[scottmg, 2017-02-16 22:27:18]

Patchset #2 (id:30001) has been deleted

[scottmg, 2017-02-16 22:27:25]

Patchset #2 (id:50001) has been deleted

[scottmg, 2017-02-16 22:27:32]

Patchset #2 (id:70001) has been deleted

[scottmg, 2017-02-16 22:33:37]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests

Currently gets as far as failing link lacking, well, the implementation for most
of base.
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests

Currently gets as far as failing link lacking, well, the implementation for most
of base. A "few" link errors:
https://gist.githubusercontent.com/sgraham/97c6be7a61df88ac86a861d0bc58a4f4/r...
.
==========

[scottmg, 2017-02-17 00:31:27]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads" is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests

Currently gets as far as failing link lacking, well, the implementation for most
of base. A "few" link errors:
https://gist.githubusercontent.com/sgraham/97c6be7a61df88ac86a861d0bc58a4f4/r...
.
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads"
fuchsia_sysroot_location="/work/fuchsia/out/sysroot" is_debug=true
symbol_level=2' --check


$ ninja -C out/fuch base_unittests
==========

[jamesr, 2017-02-17 00:44:09]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2017-02-17 00:44:10]

https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h
File base/command_line.h (right):

https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h#ne...
base/command_line.h:37: #elif defined(OS_POSIX) || defined(OS_FUCHSIA)
I think OS_POSIX should be true when current_os == "fuchsia"

[jamesr, 2017-02-17 00:47:36]

https://codereview.chromium.org/2692273008/diff/110001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2692273008/diff/110001/BUILD.gn#newcode41
BUILD.gn:41: is_fuchsia = current_os == "fuchsia"
ideally this would be in
https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?q=BUILDCONFI...

https://codereview.chromium.org/2692273008/diff/110001/build/toolchain/toolch...
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2692273008/diff/110001/build/toolchain/toolch...
build/toolchain/toolchain.gni:92: shlib_extension = ".so"  # ?
that is the shared library extension for fuchsia. i think this should fall out
of the is_posix bit, though

[scottmg, 2017-02-17 00:48:11]

https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h
File base/command_line.h (right):

https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h#ne...
base/command_line.h:37: #elif defined(OS_POSIX) || defined(OS_FUCHSIA)
On 2017/02/17 00:44:10, jamesr wrote:
> I think OS_POSIX should be true when current_os == "fuchsia"

Thanks! I waffled on that for a while. I wasn't sure what your deal with files
was, but now I see it's pretty normal unistd.

There's no pthread in favour of C11 threads, is that right?

I guess OS_POSIX will probably require a smaller delta, even if someday it's
better for it to be false.

[scottmg, 2017-02-17 00:50:45]

https://codereview.chromium.org/2692273008/diff/110001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2692273008/diff/110001/BUILD.gn#newcode41
BUILD.gn:41: is_fuchsia = current_os == "fuchsia"
On 2017/02/17 00:47:35, jamesr wrote:
> ideally this would be in
>
https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?q=BUILDCONFI...

Agreed, I wasn't sure what the general feeling was on whether Fuchsia had
exceeded QNX and FreeBSD-level yet. :o

But it would make comparisons less ugly for sure.

[jamesr, 2017-02-17 01:41:36]

On 2017/02/17 at 00:48:11, scottmg wrote:
> https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h
> File base/command_line.h (right):
> 
>
https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h#ne...
> base/command_line.h:37: #elif defined(OS_POSIX) || defined(OS_FUCHSIA)
> On 2017/02/17 00:44:10, jamesr wrote:
> > I think OS_POSIX should be true when current_os == "fuchsia"
> 
> Thanks! I waffled on that for a while. I wasn't sure what your deal with files
was, but now I see it's pretty normal unistd.
> 
> There's no pthread in favour of C11 threads, is that right?

pthreads works and is supported.  We prefer and recommend using C11 threads, and
do so in our first-party code, but support pthreads and will fix any bugs /
necessary missing features.  We support other codebases that use pthreads.


> 
> I guess OS_POSIX will probably require a smaller delta, even if someday it's
better for it to be false.

[scottmg, 2017-02-17 02:20:33]

On 2017/02/17 01:41:36, jamesr wrote:
> On 2017/02/17 at 00:48:11, scottmg wrote:
> > https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h
> > File base/command_line.h (right):
> > 
> >
>
https://codereview.chromium.org/2692273008/diff/110001/base/command_line.h#ne...
> > base/command_line.h:37: #elif defined(OS_POSIX) || defined(OS_FUCHSIA)
> > On 2017/02/17 00:44:10, jamesr wrote:
> > > I think OS_POSIX should be true when current_os == "fuchsia"
> > 
> > Thanks! I waffled on that for a while. I wasn't sure what your deal with
files
> was, but now I see it's pretty normal unistd.
> > 
> > There's no pthread in favour of C11 threads, is that right?
> 
> pthreads works and is supported.  We prefer and recommend using C11 threads,
and
> do so in our first-party code, but support pthreads and will fix any bugs /
> necessary missing features.  We support other codebases that use pthreads.

OK, sounds like I should pitch most of this and try a more POSIXy version then.
Thanks for taking a look.

> 
> > 
> > I guess OS_POSIX will probably require a smaller delta, even if someday it's
> better for it to be false.

[scottmg, 2017-02-17 19:19:02]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sdk="/work/fuchsia/magenta/prebuilt/downloads"
fuchsia_sysroot_location="/work/fuchsia/out/sysroot" is_debug=true
symbol_level=2' --check


$ ninja -C out/fuch base_unittests
==========

to

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sysroot_location="/work/fuchsia/out/sysroot" use_gold=true is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests
==========

[jamesr, 2017-02-18 00:18:40]

https://codereview.chromium.org/2692273008/diff/230001/build/config/fuchsia/B...
File build/config/fuchsia/BUILD.gn (right):

https://codereview.chromium.org/2692273008/diff/230001/build/config/fuchsia/B...
build/config/fuchsia/BUILD.gn:35: "-lmxio",
could these just go in 'libs' ?

https://codereview.chromium.org/2692273008/diff/230001/build/toolchain/toolch...
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2692273008/diff/230001/build/toolchain/toolch...
build/toolchain/toolchain.gni:92: shlib_extension = ".so"  # ?
".so" is correct for fuchsia

https://codereview.chromium.org/2692273008/diff/230001/build/toolchain/toolch...
build/toolchain/toolchain.gni:92: shlib_extension = ".so"  # ?
".so" is correct for fuchsia

https://codereview.chromium.org/2692273008/diff/230001/remoting/remoting_enab...
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/2692273008/diff/230001/remoting/remoting_enab...
remoting/remoting_enable.gni:10: !is_ios && !is_chromecast && current_os !=
"fuchsia" && enable_webrtc
could be is_fuchsia, now

[scottmg, 2017-02-18 00:25:20]

got rid of //fuchsia/BUILD.gn too.

https://codereview.chromium.org/2692273008/diff/230001/build/config/fuchsia/B...
File build/config/fuchsia/BUILD.gn (right):

https://codereview.chromium.org/2692273008/diff/230001/build/config/fuchsia/B...
build/config/fuchsia/BUILD.gn:35: "-lmxio",
On 2017/02/18 00:18:40, jamesr wrote:
> could these just go in 'libs' ?

Done.

https://codereview.chromium.org/2692273008/diff/230001/build/toolchain/toolch...
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2692273008/diff/230001/build/toolchain/toolch...
build/toolchain/toolchain.gni:92: shlib_extension = ".so"  # ?
On 2017/02/18 00:18:40, jamesr wrote:
> ".so" is correct for fuchsia

Done.

https://codereview.chromium.org/2692273008/diff/230001/remoting/remoting_enab...
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/2692273008/diff/230001/remoting/remoting_enab...
remoting/remoting_enable.gni:10: !is_ios && !is_chromecast && current_os !=
"fuchsia" && enable_webrtc
On 2017/02/18 00:18:40, jamesr wrote:
> could be is_fuchsia, now

Done.

[scottmg, 2017-02-18 00:26:05]

Description was changed from

==========
Hacky slashy

XXX Prototype only, not for comment or review.

$ gn gen out/fuch --args='target_os="fuchsia" host_cpu="x64"
v8_use_external_startup_data=false
fuchsia_sysroot_location="/work/fuchsia/out/sysroot" use_gold=true is_debug=true
symbol_level=2' --check

$ ninja -C out/fuch base_unittests
==========

to

==========
Hacky slashy

XXX Prototype only

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests
==========

[jamesr, 2017-02-18 00:55:28]

https://codereview.chromium.org/2692273008/diff/250001/build/config/compiler/...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2692273008/diff/250001/build/config/compiler/...
build/config/compiler/BUILD.gn:334: ldflags += [ "-Wl,--as-needed" ]
recording for posterity: you can have this flag, the only library we have that
doesn't work well is 'mxio'. You can work around this by leaving this alone and
in //build/config/fuchsia/BUILD.gn doing

ldflags = [
  "-Wl,--no-as-needed",
  "-lmxio",  // The mxio library is needed, even if the linker does not see
direct references to it
  "-Wl,--as-needed",
]

[scottmg, 2017-02-20 22:12:53]

Description was changed from

==========
Hacky slashy

XXX Prototype only

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests
==========

to

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests
==========

[scottmg, 2017-02-20 22:14:30]

Description was changed from

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests
==========

to

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

Ctrl-A, X exits QEMU.
==========

[scottmg, 2017-02-20 22:44:17]

Description was changed from

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

Ctrl-A, X exits QEMU.
==========

to

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

A command that runs some tests that passes and fails, excluding a bunch of tests
that CHECK or crash:

system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*
system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*:MessageFormatterTest.*:ICU*:NumberFormatting*:RTLTest*:TimeFormatting*:*ErrorMessages*:JSONReaderTest*:MemoryPressureListenerTest*:SharedMemoryTest*:MessageLoopTest*:FieldTrial*:PersistentHisto*:*PersistentMemory*:NativeLibraryTest.*:PathServiceTest.*:ProcessUtilTest*:RandUtilTest*:WaitableEventWatcher*:SysInfoTest.*:TaskSchedulerLock.*:TaskScheduler*:TimerTest.*:AllocationRegisterTest*:UnguessableToken*:PartitionAlloc*

Ctrl-A, X exits QEMU.
==========

[scottmg, 2017-02-20 22:47:35]

Description was changed from

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

A command that runs some tests that passes and fails, excluding a bunch of tests
that CHECK or crash:

system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*
system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*:MessageFormatterTest.*:ICU*:NumberFormatting*:RTLTest*:TimeFormatting*:*ErrorMessages*:JSONReaderTest*:MemoryPressureListenerTest*:SharedMemoryTest*:MessageLoopTest*:FieldTrial*:PersistentHisto*:*PersistentMemory*:NativeLibraryTest.*:PathServiceTest.*:ProcessUtilTest*:RandUtilTest*:WaitableEventWatcher*:SysInfoTest.*:TaskSchedulerLock.*:TaskScheduler*:TimerTest.*:AllocationRegisterTest*:UnguessableToken*:PartitionAlloc*

Ctrl-A, X exits QEMU.
==========

to

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

A command that runs some tests that passes and fails, excluding a bunch of tests
that CHECK or crash:

system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*:MessageFormatterTest.*:ICU*:NumberFormatting*:RTLTest*:TimeFormatting*:*ErrorMessages*:JSONReaderTest*:MemoryPressureListenerTest*:SharedMemoryTest*:MessageLoopTest*:FieldTrial*:PersistentHisto*:*PersistentMemory*:NativeLibraryTest.*:PathServiceTest.*:ProcessUtilTest*:RandUtilTest*:WaitableEventWatcher*:SysInfoTest.*:TaskSchedulerLock.*:TaskScheduler*:TimerTest.*:AllocationRegisterTest*:UnguessableToken*:PartitionAlloc*

Ctrl-A, X exits QEMU.
==========

[cpu_(ooo_6.6-7.5), 2017-02-20 23:22:15]

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
File base/process/process_handle_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
base/process/process_handle_fuchsia.cc:11: // TODO(scottmg): Port.
we don't have this. A possible approximation is the parent job object koid
obtained via  |related_koid|

https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in...

https://codereview.chromium.org/2692273008/diff/350001/base/process/process_h...
File base/process/process_handle_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/350001/base/process/process_h...
base/process/process_handle_fuchsia.cc:17: return FilePath();
there might not be a file backing a process, but there is a free form |name|
property that if you squint reads (sometimes) like a path via

 mx_object_get_property(handle, MX_PROP_NAME, name, sizeof(name));

better than nothing ...

https://codereview.chromium.org/2692273008/diff/350001/base/sys_info_fuchsia.cc
File base/sys_info_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/350001/base/sys_info_fuchsia....
base/sys_info_fuchsia.cc:11: return 0;
I'll get a bug on this

[scottmg, 2017-02-20 23:37:01]

Description was changed from

==========
Hacky slashy

XXX Prototype only

Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk, then:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This will get you to a QEMU prompt; for the moment you have to then manually
run "system/base_unittests --single-process-test" inside the VM.

A command that runs some tests that passes and fails, excluding a bunch of tests
that CHECK or crash:

system/base_unittests --single-process-tests
--gtest_filter=-FeatureListTest.*:FileLockingTest.*:FileProxyTest.*:GUIDTest.*:BreakIteratorTest.*:MessageFormatterTest.*:ICU*:NumberFormatting*:RTLTest*:TimeFormatting*:*ErrorMessages*:JSONReaderTest*:MemoryPressureListenerTest*:SharedMemoryTest*:MessageLoopTest*:FieldTrial*:PersistentHisto*:*PersistentMemory*:NativeLibraryTest.*:PathServiceTest.*:ProcessUtilTest*:RandUtilTest*:WaitableEventWatcher*:SysInfoTest.*:TaskSchedulerLock.*:TaskScheduler*:TimerTest.*:AllocationRegisterTest*:UnguessableToken*:PartitionAlloc*

Ctrl-A, X exits QEMU.
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a


$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This runs base_unittests under QEMU, and outputs the results. Note that a bunch
of
tests are currently filtered out.
==========

[scottmg, 2017-02-20 23:37:10]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a


$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This runs base_unittests under QEMU, and outputs the results. Note that a bunch
of
tests are currently filtered out.
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This runs base_unittests under QEMU, and outputs the results. Note that a bunch
of
tests are currently filtered out.
==========

[scottmg, 2017-02-20 23:43:10]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

$ out/fuch/bin/run_base_unittests

This runs base_unittests under QEMU, and outputs the results. Note that a bunch
of
tests are currently filtered out.
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

[scottmg, 2017-02-21 00:30:16]

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
File base/process/process_handle_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
base/process/process_handle_fuchsia.cc:11: // TODO(scottmg): Port.
On 2017/02/20 23:22:15, cpu wrote:
> we don't have this. A possible approximation is the parent job object koid
> obtained via  |related_koid|
> 
>
https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in...

Is a koid a suitable pid? i.e. the definition of ProcessId and ProcessHandle
https://cs.chromium.org/chromium/src/base/process/process_handle.h?rcl=e80226...
should both be mx_koid_t on Fuchsia?

https://codereview.chromium.org/2692273008/diff/350001/base/process/process_h...
File base/process/process_handle_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/350001/base/process/process_h...
base/process/process_handle_fuchsia.cc:17: return FilePath();
On 2017/02/20 23:22:15, cpu wrote:
> there might not be a file backing a process, but there is a free form |name|
> property that if you squint reads (sometimes) like a path via
> 
>  mx_object_get_property(handle, MX_PROP_NAME, name, sizeof(name));
> 
> better than nothing ...

Thanks, had a go at that. (This function seems to see very limited use based on
https://cs.chromium.org/search/?q=GetProcessExecutablePath+package:%5Echromiu...
, so I'm not sure if this works or not.)

[Roland McGrath, 2017-02-21 21:11:14]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2017-02-21 21:11:16]

https://codereview.chromium.org/2692273008/diff/350001/base/sys_info_fuchsia.cc
File base/sys_info_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/350001/base/sys_info_fuchsia....
base/sys_info_fuchsia.cc:11: return 0;
We're adding an interface for this, but we'll also support the POSIX.1 interface
sysconf(_SC_PHYS_PAGES) that's used on other POSIX-esque systems.

[cpu_(ooo_6.6-7.5), 2017-02-25 23:44:10]

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
File base/process/process_handle_fuchsia.cc (right):

https://codereview.chromium.org/2692273008/diff/330001/base/process/process_h...
base/process/process_handle_fuchsia.cc:11: // TODO(scottmg): Port.
On 2017/02/21 00:30:16, scottmg wrote:
> On 2017/02/20 23:22:15, cpu wrote:
> > we don't have this. A possible approximation is the parent job object koid
> > obtained via  |related_koid|
> > 
> >
>
https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in...
> 
> Is a koid a suitable pid? i.e. the definition of ProcessId and ProcessHandle
>
https://cs.chromium.org/chromium/src/base/process/process_handle.h?rcl=e80226...
> should both be mx_koid_t on Fuchsia?

tl;dr: Yes

If you have a powerful enough handle to the parent of something you can use the
handle + child koid to obtain a handle to the child.

However koids are globaly unique, so the koid is indeed a "better" pid in the
sense of pointing to the right guy and they can actually be used if you have a
handle to the parent job. Same with tids, they are just the thread object koids.

[scottmg, 2017-03-29 21:34:52]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/4.0.0/lib/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

[scottmg, 2017-03-29 21:45:51]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

[scottmg, 2017-04-28 02:29:19]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp
third_party/fuchsia-sdk/toolchain_libs/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp
third_party/fuchsia-sdk/toolchain_libs/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

[scottmg, 2017-04-29 00:17:41]

Description was changed from

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp
third_party/fuchsia-sdk/toolchain_libs/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests

(Note that a bunch of tests are currently filtered out.)
==========

to

==========
Hacky slashy

XXX Prototype only

- Unzip Fuchsia "core sdk" into third_party/fuchsia-sdk
- Copy runtime_lib to clang dir via:

$ mkdir third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia
$ cp
third_party/fuchsia-sdk/toolchain_libs/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a
third_party/llvm-build/Release+Asserts/lib/clang/5.0.0/lib/fuchsia/libclang_rt.builtins-x86_64.a

Then, generate and build as usual:

$ gn gen out/fuch --args='target_os="fuchsia" is_debug=true symbol_level=2'
--check

$ ninja -C out/fuch base_unittests

The build generates a wrapper the bundles required binaries and test data into
an image and then launches QEMU, sending the output to stdio and then quitting
QEMU.

$ out/fuch/bin/run_base_unittests
==========

[scottmg, 2017-05-01 20:13:21]

Patchset #28 (id:600001) has been deleted