base/process/process_handle_fuchsia.cc - Issue 2692273008: Hacky slashy

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/process/process_handle_fuchsia.cc

Issue 2692273008: Hacky slashy (Closed)

Patch Set: mostly working test runner Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/macros.h"

	6 #include "base/process/process_handle.h"

	7

	8 namespace base {

	9

	10 ProcessId GetParentProcessId(ProcessHandle process) {

	11 // TODO(scottmg): Port.
	cpu_(ooo_6.6-7.5) 2017/02/20 23:22:15 we don't have this. A possible approximation is th we don't have this. A possible approximation is the parent job object koid obtained via \|related_koid\| https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in... scottmg 2017/02/21 00:30:16 Is a koid a suitable pid? i.e. the definition of P Show quoted text On 2017/02/20 23:22:15, cpu wrote: > we don't have this. A possible approximation is the parent job object koid > obtained via \|related_koid\| > > https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in... Is a koid a suitable pid? i.e. the definition of ProcessId and ProcessHandle https://cs.chromium.org/chromium/src/base/process/process_handle.h?rcl=e80226... should both be mx_koid_t on Fuchsia? cpu_(ooo_6.6-7.5) 2017/02/25 23:44:10 tl;dr: Yes If you have a powerful enough handle t Show quoted text On 2017/02/21 00:30:16, scottmg wrote: > On 2017/02/20 23:22:15, cpu wrote: > > we don't have this. A possible approximation is the parent job object koid > > obtained via \|related_koid\| > > > > > https://fuchsia.googlesource.com/magenta/+/master/docs/syscalls/object_get_in... > > Is a koid a suitable pid? i.e. the definition of ProcessId and ProcessHandle > https://cs.chromium.org/chromium/src/base/process/process_handle.h?rcl=e80226... > should both be mx_koid_t on Fuchsia? tl;dr: Yes If you have a powerful enough handle to the parent of something you can use the handle + child koid to obtain a handle to the child. However koids are globaly unique, so the koid is indeed a "better" pid in the sense of pointing to the right guy and they can actually be used if you have a handle to the parent job. Same with tids, they are just the thread object koids.
	12 return 0;

	13 }

	14

	15 FilePath GetProcessExecutablePath(ProcessHandle process) {

	16 // TODO(scottmg): Port.

	17 return FilePath();

	18 }

	19

	20 } // namespace base

OLD	NEW

« no previous file with comments | « base/process/memory.cc ('k') | base/process/process_iterator_fuchsia.cc » ('j') | no next file with comments »