Refactor safebrowsing StartDisplayingBlockingPage

Refactor safebrowsing StartDisplayingBlockingPage

Move duplicated code about ContentSubresourceFilterDriverFactory into a
separate method in the base class.

BUG=

Review-Url: https://codereview.chromium.org/2692273006
Cr-Commit-Position: refs/heads/master@{#450870}
Committed: https://chromium.googlesource.com/chromium/src/+/353c830f4a83db572dab3e949fd5bc611f519f84

[Nate Fischer, 2017-02-15 23:18:42]

The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run

[Nate Fischer, 2017-02-15 23:19:00]

ntfschr@chromium.org changed reviewers:
+ jialiul@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Fischer, 2017-02-15 23:32:18]

The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run

[Nate Fischer, 2017-02-15 23:32:38]

jialiul@: We must've missed this during componentization, but I think this is a
better refactoring. Please let me know if I can improve this in any way.

I'll wait to get chrome/browser approval until after I've received your
approval.

[commit-bot: I haz the power, 2017-02-15 23:34:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-02-15 23:50:59]

Thanks for catching this repeated segment! Looks much better now!
LGTM

[Nate Fischer, 2017-02-16 00:04:51]

ntfschr@chromium.org changed reviewers:
+ csharrison@chromium.org

[Nate Fischer, 2017-02-16 00:05:21]

csharrison@: Could you please take a look at chrome/browser/loader/? Thanks!

[Charlie Harrison, 2017-02-16 00:24:26]

LGTM

[commit-bot: I haz the power, 2017-02-16 01:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:37:18]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Nate Fischer, 2017-02-16 01:38:25]

The CQ bit was checked by ntfschr@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 04:32:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487209105692130,
"parent_rev": "6cf3aecafe0e4790a0aa0dd8f44602acce121a2e", "commit_rev":
"353c830f4a83db572dab3e949fd5bc611f519f84"}

[commit-bot: I haz the power, 2017-02-16 04:35:02]

Description was changed from

==========
Refactor safebrowsing StartDisplayingBlockingPage

Move duplicated code about ContentSubresourceFilterDriverFactory into a
separate method in the base class.

BUG=
==========

to

==========
Refactor safebrowsing StartDisplayingBlockingPage

Move duplicated code about ContentSubresourceFilterDriverFactory into a
separate method in the base class.

BUG=

Review-Url: https://codereview.chromium.org/2692273006
Cr-Commit-Position: refs/heads/master@{#450870}
Committed:
https://chromium.googlesource.com/chromium/src/+/353c830f4a83db572dab3e949fd5...
==========

[commit-bot: I haz the power, 2017-02-16 04:35:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/353c830f4a83db572dab3e949fd5...