Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2692273003: Handle mandatory arguments correctly in function type aliases. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Handle mandatory arguments correctly in function type aliases. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/490c5ff3313855dcea8b1b79e1fe697ec1c39440

Patch Set 1 #

Patch Set 2 : Missing file. #

Patch Set 3 : Remove extra line. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/front_end/test/fasta/typedef.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/typedef.dart.direct.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/typedef.dart.outline.expect View 1 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2692273003/diff/40001/pkg/front_end/test/fasta/typedef.dart.outline.expect File pkg/front_end/test/fasta/typedef.dart.outline.expect (right): https://codereview.chromium.org/2692273003/diff/40001/pkg/front_end/test/fasta/typedef.dart.outline.expect#newcode3 pkg/front_end/test/fasta/typedef.dart.outline.expect:3: There's currently no representation of typedefs in Kernel. This ...
3 years, 10 months ago (2017-02-14 10:16:16 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-14 10:32:39 UTC) #3
ahe
3 years, 10 months ago (2017-02-14 11:33:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
490c5ff3313855dcea8b1b79e1fe697ec1c39440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698