Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart

Issue 2692273003: Handle mandatory arguments correctly in function type aliases. (Closed)
Patch Set: Remove extra line. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.formal_parameter_builder; 5 library fasta.formal_parameter_builder;
6 6
7 import 'package:front_end/src/fasta/parser/parser.dart' show 7 import 'package:front_end/src/fasta/parser/parser.dart' show
8 FormalParameterType; 8 FormalParameterType;
9 9
10 import 'builder.dart' show 10 import 'builder.dart' show
(...skipping 16 matching lines...) Expand all
27 final bool hasThis; 27 final bool hasThis;
28 28
29 FormalParameterType kind = FormalParameterType.REQUIRED; 29 FormalParameterType kind = FormalParameterType.REQUIRED;
30 30
31 FormalParameterBuilder(this.metadata, this.modifiers, this.type, this.name, 31 FormalParameterBuilder(this.metadata, this.modifiers, this.type, this.name,
32 this.hasThis, LibraryBuilder compilationUnit, int charOffset) 32 this.hasThis, LibraryBuilder compilationUnit, int charOffset)
33 : super(compilationUnit, charOffset); 33 : super(compilationUnit, charOffset);
34 34
35 bool get isRequired => kind.isRequired; 35 bool get isRequired => kind.isRequired;
36 36
37 bool get isPositional => kind.isPositional; 37 bool get isPositional => kind.isPositional || kind.isRequired;
38 38
39 bool get isNamed => kind.isNamed; 39 bool get isNamed => kind.isNamed;
40 40
41 bool get isOptional => !isRequired; 41 bool get isOptional => !isRequired;
42 42
43 bool get isLocal => true; 43 bool get isLocal => true;
44 } 44 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/kompile.status » ('j') | pkg/front_end/test/fasta/typedef.dart.outline.expect » ('J')

Powered by Google App Engine
This is Rietveld 408576698