Roll FreeType from 2.7.0 + patches to 2.7.1 + patches

Roll FreeType from 2.7.0 + patches to 2.7.1 + patches

-c38be52bf8de3b1699d74932b849bf150265819e
+66725768cdf758cfb3f9abf03cbf5e5a77f42088

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38be52bf8de..66725768cd

BUG=692088
Review-Url: https://codereview.chromium.org/2692253004
Cr-Commit-Position: refs/heads/master@{#450699}
Committed: https://chromium.googlesource.com/chromium/src/+/cc27186fbdf13821e3f755f449bebbb4ef080ab5

[drott, 2017-02-14 15:22:52]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 15:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-02-14 15:23:41]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2017-02-14 15:23:58]

drott@chromium.org changed reviewers:
+ bungeman@chromium.org, jshin@chromium.org

[commit-bot: I haz the power, 2017-02-14 15:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-02-14 15:24:55]

Succesfully tested the Noto Arabic variations example on Android with this
changed.

[bungeman-chromium, 2017-02-14 15:56:18]

lgtm

I haven't checked, and there probably aren't any changes to ftoption.h since the
last roll, but I usually just run a diff against the local ftoption.h and the
now DEPS'ed in ftoption.h (as described in README.chromium) and update the local
ftoption.h to track the new one as needed, mostly just to keep them from getting
too out of sync.

Also, it's nice if the commit message has a link to the revisions rolled. Like

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

[bungeman-chromium, 2017-02-14 15:56:58]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+069083cccd73d1d68da68116c8d050bb62cdfe0e

No changes to ftoption.h

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+069083cccd73d1d68da68116c8d050bb62cdfe0e

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

No changes to ftoption.h

BUG=692088
==========

[bungeman-chromium, 2017-02-14 15:58:31]

Actually, you should go to at least e9a154e since the commit after the release
was tagged is an overflow fix found by the fuzzers.

[bungeman-chromium, 2017-02-14 16:00:55]

On 2017/02/14 15:58:31, bungeman-chromium wrote:
> Actually, you should go to at least e9a154e since the commit after the release
> was tagged is an overflow fix found by the fuzzers.

Actually, a few after that 248eaa4 fixed a few more. The 2.7.1 tag is pretty old
at this point, and the FreeType tagging seems a little bit arbitrary (based
mostly on features being available). The tag is 7 weeks old at this point,
probably better to roll to a newer commit. Now that FreeType is being rather
heavily fuzzed, it's probably best to pick something closer to tip of tree.

[commit-bot: I haz the power, 2017-02-14 16:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:30:31]

Dry run: This issue passed the CQ dry run.

[drott, 2017-02-15 07:44:41]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+069083cccd73d1d68da68116c8d050bb62cdfe0e

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

No changes to ftoption.h

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

No changes to ftoption.h

BUG=692088
==========

[drott, 2017-02-15 07:49:15]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

No changes to ftoption.h

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

[drott, 2017-02-15 07:51:26]

Thanks for the review, moved to current ToT now. Yes, I did the diff for
ftoption.h and there (previously) weren't any changes. With going to current
ToT, there is a new PCF option. Reflected in the updated CL. Thanks for taking
another look.

[drott, 2017-02-15 07:52:10]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1 + patches (e432ebf2e2c)

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

[drott, 2017-02-15 07:52:24]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 07:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 08:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 08:16:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[drott, 2017-02-15 12:06:39]

Rolls further than 66725768cdf758cfb3f9abf03cbf5e5a77f42088 blocked on
https://savannah.nongnu.org/bugs/index.php?50313

[drott, 2017-02-15 12:07:17]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1 + patches (e432ebf2e2c)

-c38be52bf8de3b1699d74932b849bf150265819e
+e432ebf2e2c96e75f674af41f062d8b210de8491

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1 + patches

-c38be52bf8de3b1699d74932b849bf150265819e
+66725768cdf758cfb3f9abf03cbf5e5a77f42088

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

[drott, 2017-02-15 12:07:23]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 12:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 13:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 13:34:05]

Dry run: This issue passed the CQ dry run.

[drott, 2017-02-15 15:04:00]

The CQ bit was checked by drott@chromium.org

[drott, 2017-02-15 15:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
bungeman@chromium.org
Link to the patchset: https://codereview.chromium.org/2692253004/#ps40001
(title: "Only roll to 66725768cdf758cfb3f9abf03cbf5e5a77f42088, after which
fontconfig build on cast_shell b…")

[commit-bot: I haz the power, 2017-02-15 15:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 15:08:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487171040871070,
"parent_rev": "63663601e71375d247ead1b5f38fd331dcb122df", "commit_rev":
"cc27186fbdf13821e3f755f449bebbb4ef080ab5"}

[commit-bot: I haz the power, 2017-02-15 15:09:10]

Description was changed from

==========
Roll FreeType from 2.7.0 + patches to 2.7.1 + patches

-c38be52bf8de3b1699d74932b849bf150265819e
+66725768cdf758cfb3f9abf03cbf5e5a77f42088

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088
==========

to

==========
Roll FreeType from 2.7.0 + patches to 2.7.1 + patches

-c38be52bf8de3b1699d74932b849bf150265819e
+66725768cdf758cfb3f9abf03cbf5e5a77f42088

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/c38...

BUG=692088

Review-Url: https://codereview.chromium.org/2692253004
Cr-Commit-Position: refs/heads/master@{#450699}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc27186fbdf13821e3f755f449be...
==========

[commit-bot: I haz the power, 2017-02-15 15:09:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cc27186fbdf13821e3f755f449be...