[dashboard] Use fuzzy autocomplete in autocomplete-box

[dashboard] Use fuzzy autocomplete in autocomplete-box

Provides FuzzyAutocomplete, a drop in replacement
for Trie. FuzzyAutocomplete matches a string with a query
if each whitespace separated word in the query appears
somewhere in the string. It sorts the results alphabetically
rather than via a score as Trie does. 

BUG=catapult:#3212

Review-Url: https://codereview.chromium.org/2692243003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/16aa40a74e4b6003fb94789fdb8bf680881da435

[hjd, 2017-02-14 12:33:25]

Description was changed from

==========
switch autocomplete for fuzzy search

BUG=catapult:#
==========

to

==========
switch autocomplete for fuzzy search

BUG=catapult:#3212
==========

[hjd, 2017-02-14 13:53:21]

Description was changed from

==========
switch autocomplete for fuzzy search

BUG=catapult:#3212
==========

to

==========
[dashboard] Use fuzzy autocomplete in autocomplete-box

Provides FuzzyAutocomplete, a drop in replacement
for Trie. FuzzyAutocomplete matches a string with a query
if each whitespace separated word in the query appears
somewhere in the string. It sorts the results alphabetically
rather than via a score as Trie does. 

BUG=catapult:#3212
==========

[shatch, 2017-02-14 20:33:27]

simonhatch@chromium.org changed reviewers:
+ simonhatch@chromium.org

[shatch, 2017-02-14 20:33:27]

This is awesome.

https://codereview.chromium.org/2692243003/diff/40001/dashboard/dashboard/sta...
File dashboard/dashboard/static/fuzzy_autocomplete.html (right):

https://codereview.chromium.org/2692243003/diff/40001/dashboard/dashboard/sta...
dashboard/dashboard/static/fuzzy_autocomplete.html:33:
FuzzyAutocomplete.prototype.cmpItems_ = function(a, b) {
Only one issue I saw from using the demo, when you went to the first box "Test
Suite" and starting typing "system_he" it auto-completes but the system_health.*
benchmarks are way down the list. I patched in your CL and hacked up a small
change which assigned a ranking value to each item based on accumulated index of
the regex matches (with a slight change to those).

Poorly coded demo here:
https://dev-simonhatch-b53b7fb8-dot-chromeperf.appspot.com/report

[hjd, 2017-02-15 12:07:27]

On 2017/02/14 20:33:27, shatch wrote:
> This is awesome.
> 
>
https://codereview.chromium.org/2692243003/diff/40001/dashboard/dashboard/sta...
> File dashboard/dashboard/static/fuzzy_autocomplete.html (right):
> 
>
https://codereview.chromium.org/2692243003/diff/40001/dashboard/dashboard/sta...
> dashboard/dashboard/static/fuzzy_autocomplete.html:33:
> FuzzyAutocomplete.prototype.cmpItems_ = function(a, b) {
> Only one issue I saw from using the demo, when you went to the first box "Test
> Suite" and starting typing "system_he" it auto-completes but the
system_health.*
> benchmarks are way down the list. I patched in your CL and hacked up a small
> change which assigned a ranking value to each item based on accumulated index
of
> the regex matches (with a slight change to those).
> 
> Poorly coded demo here:
> https://dev-simonhatch-b53b7fb8-dot-chromeperf.appspot.com/report

Great idea, trying to get to system_health.memory_mobile annoyed
me as well when trying out this CL so that seems like a good plan.
I stole the score function and added a few more tests. Thanks!

Demo: https://clean-hjd-22c38d4b-dot-chromeperf.appspot.com/report

[shatch, 2017-02-15 15:06:13]

simonhatch@chromium.org changed reviewers:
+ sullivan@chromium.org

[shatch, 2017-02-15 15:06:13]

Yeah that demo works really well, much slicker than what we have now! lgtm

https://codereview.chromium.org/2692243003/diff/60001/dashboard/dashboard/sta...
File dashboard/dashboard/static/fuzzy_autocomplete.html (right):

https://codereview.chromium.org/2692243003/diff/60001/dashboard/dashboard/sta...
dashboard/dashboard/static/fuzzy_autocomplete.html:36: var itemToKey = new
Map();
nit: Would probably be more straightforward to just make an array of these keys,
sort, and then return a mapping of them to the items.

ie.

var resultsToSort = results.map(item => toKey(item));
return resultsToSort.sort().map(key => key[0]);

[hjd, 2017-02-15 15:41:51]

On 2017/02/15 15:06:13, shatch wrote:
> Yeah that demo works really well, much slicker than what we have now! lgtm
> 
>
https://codereview.chromium.org/2692243003/diff/60001/dashboard/dashboard/sta...
> File dashboard/dashboard/static/fuzzy_autocomplete.html (right):
> 
>
https://codereview.chromium.org/2692243003/diff/60001/dashboard/dashboard/sta...
> dashboard/dashboard/static/fuzzy_autocomplete.html:36: var itemToKey = new
> Map();
> nit: Would probably be more straightforward to just make an array of these
keys,
> sort, and then return a mapping of them to the items.
> 
> ie.
> 
> var resultsToSort = results.map(item => toKey(item));
> return resultsToSort.sort().map(key => key[0]);

Yeah, that does seem nicer, thanks! :)

[hjd, 2017-02-15 15:46:29]

The CQ bit was checked by hjd@chromium.org

[hjd, 2017-02-15 15:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
simonhatch@chromium.org
Link to the patchset: https://codereview.chromium.org/2692243003/#ps80001
(title: "use decorate sort un-decorate pattern")

[commit-bot: I haz the power, 2017-02-15 15:46:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 15:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 15:48:42]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[hjd, 2017-02-15 16:23:25]

The CQ bit was checked by hjd@chromium.org

[hjd, 2017-02-15 16:23:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
simonhatch@chromium.org
Link to the patchset: https://codereview.chromium.org/2692243003/#ps100001
(title: "remove else")

[commit-bot: I haz the power, 2017-02-15 16:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 16:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 16:26:20]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[hjd, 2017-02-15 16:35:31]

On 2017/02/15 15:48:42, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

oops, I need

[hjd, 2017-02-15 16:36:11]

On 2017/02/15 16:35:31, hjd wrote:
> On 2017/02/15 15:48:42, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

oops, I still need an OWNERS stamp

[sullivan, 2017-02-15 21:49:29]

The CQ bit was checked by sullivan@chromium.org

[sullivan, 2017-02-15 21:49:29]

lgtm

[commit-bot: I haz the power, 2017-02-15 21:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 21:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:52:12]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[hjd, 2017-02-15 22:03:38]

The CQ bit was checked by hjd@chromium.org

[hjd, 2017-02-15 22:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, simonhatch@chromium.org
Link to the patchset: https://codereview.chromium.org/2692243003/#ps120001
(title: "fix 2nd new presubmit")

[commit-bot: I haz the power, 2017-02-15 22:03:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:05:50]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487196218962930,
"parent_rev": "2692cf5e7d5d6ad6530753e41d6c678d705d41ff", "commit_rev":
"16aa40a74e4b6003fb94789fdb8bf680881da435"}

[commit-bot: I haz the power, 2017-02-15 23:05:54]

Description was changed from

==========
[dashboard] Use fuzzy autocomplete in autocomplete-box

Provides FuzzyAutocomplete, a drop in replacement
for Trie. FuzzyAutocomplete matches a string with a query
if each whitespace separated word in the query appears
somewhere in the string. It sorts the results alphabetically
rather than via a score as Trie does. 

BUG=catapult:#3212
==========

to

==========
[dashboard] Use fuzzy autocomplete in autocomplete-box

Provides FuzzyAutocomplete, a drop in replacement
for Trie. FuzzyAutocomplete matches a string with a query
if each whitespace separated word in the query appears
somewhere in the string. It sorts the results alphabetically
rather than via a score as Trie does. 

BUG=catapult:#3212

Review-Url: https://codereview.chromium.org/2692243003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-15 23:05:57]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...