Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692233004:
Invalidate FrameView paint properties on frame rect change only when necessary (Closed)
DescriptionInvalidate FrameView paint properties on frame rect change only when necessary
Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it
in setFrameRect() and scrollContents(). This avoids unnecessary tree walk
to the child frames when the main frame is scrolled.
BUG=685179
TEST=all existing tests pass
Review-Url: https://codereview.chromium.org/2692233004
Cr-Commit-Position: refs/heads/master@{#450767}
Committed: https://chromium.googlesource.com/chromium/src/+/a1a74229c4c0c5c47dd52d88cdb42abc0802fd3f
Patch Set 1 #Patch Set 2 : - #Patch Set 3 : - #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Invalidate FrameView paint properties on frame rect change only when necessary BUG=685179 ========== to ========== Invalidate FrameView paint properties on frame rect change only when necessary - Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames (change of frame rect location) when the main frame is scrolled. - Remove setNeedsPaintPropertyUpdate() from show() and hide() because we no longer output scroll property, and update of scrollTranslation property has been covered by the existing setNeedsPaintPropertyUpdate() in updateScrollbars(). BUG=685179 TEST=all existing tests pass ==========
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org, pdr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm
Description was changed from ========== Invalidate FrameView paint properties on frame rect change only when necessary - Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames (change of frame rect location) when the main frame is scrolled. - Remove setNeedsPaintPropertyUpdate() from show() and hide() because we no longer output scroll property, and update of scrollTranslation property has been covered by the existing setNeedsPaintPropertyUpdate() in updateScrollbars(). BUG=685179 TEST=all existing tests pass ========== to ========== Invalidate FrameView paint properties on frame rect change only when necessary - Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames (change of frame rect location) when the main frame is scrolled. BUG=685179 TEST=all existing tests pass ==========
Description was changed from ========== Invalidate FrameView paint properties on frame rect change only when necessary - Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames (change of frame rect location) when the main frame is scrolled. BUG=685179 TEST=all existing tests pass ========== to ========== Invalidate FrameView paint properties on frame rect change only when necessary Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames when the main frame is scrolled. BUG=685179 TEST=all existing tests pass ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the patchset: https://codereview.chromium.org/2692233004/#ps40001 (title: "-")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487184520849270,
"parent_rev": "3fadb49c64f97201f9a328052a11ad07d01e9cbd", "commit_rev":
"a1a74229c4c0c5c47dd52d88cdb42abc0802fd3f"}
Message was sent while issue was closed.
Description was changed from ========== Invalidate FrameView paint properties on frame rect change only when necessary Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames when the main frame is scrolled. BUG=685179 TEST=all existing tests pass ========== to ========== Invalidate FrameView paint properties on frame rect change only when necessary Remove setNeedsPaintPropertyUpdate() from frameRectsChanged(), and add it in setFrameRect() and scrollContents(). This avoids unnecessary tree walk to the child frames when the main frame is scrolled. BUG=685179 TEST=all existing tests pass Review-Url: https://codereview.chromium.org/2692233004 Cr-Commit-Position: refs/heads/master@{#450767} Committed: https://chromium.googlesource.com/chromium/src/+/a1a74229c4c0c5c47dd52d88cdb4... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a1a74229c4c0c5c47dd52d88cdb4... |
