runtime/bin/bin.gypi - Issue 2692223002: Teach gen_snapshot how to create script snapshots if given a core snapshot to create them against.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/bin.gypi

Issue 2692223002: Teach gen_snapshot how to create script snapshots if given a core snapshot to create them against. (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/bin.gypi

diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi

index 3119ce0da94f1e746ef639b5aee2b2d4c7a4deeb..f5e2a631a761c1e8365c83de721583756f9611fc 100644

--- a/runtime/bin/bin.gypi

+++ b/runtime/bin/bin.gypi

@@ -1000,8 +1000,9 @@

'tools/create_snapshot_bin.py',

'--executable',

'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',

+ '--snapshot_kind', 'core',

'--vm_output_bin', '<(vm_isolate_snapshot_bin_file)',

- '--output_bin', '<(isolate_snapshot_bin_file)',

+ '--isolate_output_bin', '<(isolate_snapshot_bin_file)',

'--target_os', '<(OS)',

'--timestamp_file', '<(gen_snapshot_stamp_file)',

« no previous file with comments | « runtime/bin/BUILD.gn ('k') | runtime/bin/dartutils.cc » ('j') | no next file with comments »