Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/BUILD.gn

Issue 2692223002: Teach gen_snapshot how to create script snapshots if given a core snapshot to create them against. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 3404bbf32ccabc8f919ed7f71b41391a942bb326..0f41578c939b37a168aa166e58cd932b838e57c8 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -482,9 +482,11 @@ action("generate_snapshot_bin") {
args = [
"--executable",
rebase_path("$gen_snapshot_dir/gen_snapshot"),
+ "--snapshot_kind",
+ "core",
"--vm_output_bin",
rebase_path(vm_isolate_snapshot, root_build_dir),
- "--output_bin",
+ "--isolate_output_bin",
rebase_path(isolate_snapshot, root_build_dir),
"--target_os",
current_os,
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698