Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2692203008: Loading: use MockFetchContext in ImageResourceTest (Closed)

Created:
3 years, 10 months ago by Takashi Toyoshima
Modified:
3 years, 10 months ago
Reviewers:
yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: use MockFetchContext in ImageResourceTest ImageResourceTest still has a FetchContext subclass for testing. But MockFetchContext can replace it. BUG=655920 Review-Url: https://codereview.chromium.org/2692203008 Cr-Commit-Position: refs/heads/master@{#451221} Committed: https://chromium.googlesource.com/chromium/src/+/96ce5a090b950b68977e03b4c8f5e10d5ab8949d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -84 lines) Patch
M third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 22 chunks +30 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/MockFetchContext.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Takashi Toyoshima
ptal
3 years, 10 months ago (2017-02-16 12:45:50 UTC) #5
yhirano
lgtm. > ImageResourceTest still have has
3 years, 10 months ago (2017-02-17 03:48:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692203008/1
3 years, 10 months ago (2017-02-17 04:33:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 05:05:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96ce5a090b950b68977e03b4c8f5...

Powered by Google App Engine
This is Rietveld 408576698