Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: components/prefs/pref_store.h

Issue 2692203007: Add PrefStore::GetValues (Closed)
Patch Set: Address review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/overlay_user_pref_store.cc ('k') | components/prefs/pref_value_map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/pref_store.h
diff --git a/components/prefs/pref_store.h b/components/prefs/pref_store.h
index ef2bc494d150b8d2366a72f1dfd36f282e553687..afe362057cf062c6dfdb7779ad3637d664983a05 100644
--- a/components/prefs/pref_store.h
+++ b/components/prefs/pref_store.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_PREFS_PREF_STORE_H_
#define COMPONENTS_PREFS_PREF_STORE_H_
+#include <memory>
#include <string>
#include "base/macros.h"
@@ -12,6 +13,7 @@
#include "components/prefs/base_prefs_export.h"
namespace base {
+class DictionaryValue;
class Value;
}
@@ -52,6 +54,9 @@ class COMPONENTS_PREFS_EXPORT PrefStore : public base::RefCounted<PrefStore> {
virtual bool GetValue(const std::string& key,
const base::Value** result) const = 0;
+ // Get all the values.
Sam McNally 2017/02/20 00:31:11 Document whether this can return null.
tibell 2017/02/20 03:05:09 Done.
+ virtual std::unique_ptr<base::DictionaryValue> GetValues() const = 0;
+
protected:
friend class base::RefCounted<PrefStore>;
virtual ~PrefStore() {}
« no previous file with comments | « components/prefs/overlay_user_pref_store.cc ('k') | components/prefs/pref_value_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698