content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 2692173003: Implemented SetSelection for the Web content on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 2692173003: Implemented SetSelection for the Web content on Windows. (Closed)

Patch Set: Fixed another compilation error on Windows. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/accessibility/browser_accessibility_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 3f7121b56d738c3ce28a7fc38afc1c5534ee0aca..1c4057918678276fecda2308cc0e8ec4aeb3fbb9 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -654,8 +654,10 @@ void BrowserAccessibilityManagerAndroid::SetSelection(

jint start,

jint end) {

BrowserAccessibilityAndroid* node = GetFromUniqueID(id);

- if (node)

- node->manager()->SetTextSelection(*node, start, end);

+ if (node) {

+ node->manager()->SetSelection(AXPlatformRange(node->CreatePositionAt(start),

+ node->CreatePositionAt(end)));

+ }

}

jboolean BrowserAccessibilityManagerAndroid::AdjustSlider(