Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2692173002: Update the Bling omnibox to be aware of HTTP_SHOW_WARNING and use ShouldAlwaysShowIcon(). (Closed)

Created:
3 years, 10 months ago by lgarron
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the Bling omnibox to be aware of HTTP_SHOW_WARNING and use ShouldAlwaysShowIcon(). BUG=647559, 673530 Review-Url: https://codereview.chromium.org/2692173002 Cr-Commit-Position: refs/heads/master@{#454399} Committed: https://chromium.googlesource.com/chromium/src/+/76c172851a33d32e6eee07701d9ed8821b0e2a30

Patch Set 1 #

Patch Set 2 : Update the Bling omnibox to be aware of HTTP_SHOW_WARNING and use ShouldAlwaysShowIcon(). #

Patch Set 3 : Update the Bling omnibox to be aware of HTTP_SHOW_WARNING and use ShouldAlwaysShowIcon(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ios/chrome/browser/ui/omnibox/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
lgarron
rohitrao@, could you (re-)review? This is the upstream version of https://chromereviews.googleplex.com/556027013, unchanged in content but ...
3 years, 10 months ago (2017-02-13 23:51:56 UTC) #2
lgarron
On 2017/02/13 at 23:51:56, lgarron wrote: > rohitrao@, could you (re-)review? > > This is ...
3 years, 9 months ago (2017-02-27 20:13:35 UTC) #11
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-02 18:30:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692173002/40001
3 years, 9 months ago (2017-03-02 21:05:15 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:11:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76c172851a33d32e6eee07701d9e...

Powered by Google App Engine
This is Rietveld 408576698