Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2692123004: Uncomment tracking macro in IPC_MESSAGE_HANDLER_GENERIC (Closed)

Created:
3 years, 10 months ago by ssid
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uncomment tracking macro in IPC_MESSAGE_HANDLER_GENERIC This was commented by codereview.chromium.org/8463033 because of failures in ASAN bots. The reason says some hint about some message not supplying |code| argument. Currently we do not have any code that calls this macro with empty |code|. So, I am guessing that this issue is fixed. If this causes ASAN problems with browser tests, then I'll revert it. BUG=594803 Review-Url: https://codereview.chromium.org/2692123004 Cr-Commit-Position: refs/heads/master@{#450905} Committed: https://chromium.googlesource.com/chromium/src/+/36b5511e4f35e3063317921e3b623cec5dbe0caa

Patch Set 1 : format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ipc/ipc_message_macros.h View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
ssid
+rockot ptal small change, thanks!
3 years, 10 months ago (2017-02-15 01:23:59 UTC) #5
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-15 01:28:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692123004/20001
3 years, 10 months ago (2017-02-16 06:50:33 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 09:00:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36b5511e4f35e3063317921e3b62...

Powered by Google App Engine
This is Rietveld 408576698