Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2692123003: Enable new wpt/service-workers/service-worker/multi-globals tests. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
shimazu
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable new wpt/service-workers/service-worker/multi-globals tests. R=shimazu@chromium.org BUG=692105 Review-Url: https://codereview.chromium.org/2692123003 Cr-Commit-Position: refs/heads/master@{#450789} Committed: https://chromium.googlesource.com/chromium/src/+/aa05762f650b9bf8ccc6baf44991ae2e283b7d1f

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/multi-globals/url-parsing.https-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
qyearsley
3 years, 10 months ago (2017-02-15 00:27:44 UTC) #2
shimazu
Thanks! LGTM.
3 years, 10 months ago (2017-02-15 00:41:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692123003/40001
3 years, 10 months ago (2017-02-15 17:29:16 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-15 18:53:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692123003/60001
3 years, 10 months ago (2017-02-15 19:09:20 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 20:41:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aa05762f650b9bf8ccc6baf44991...

Powered by Google App Engine
This is Rietveld 408576698